From 03ca5c3b26d5db5d592e9233f6743b35f9a4dab9 Mon Sep 17 00:00:00 2001 From: Hajime Hoshi Date: Sat, 13 Jul 2024 23:08:25 +0900 Subject: [PATCH] audio/internal/convert: bug fix: skip tests on browsers correctly --- audio/internal/convert/float32_test.go | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/audio/internal/convert/float32_test.go b/audio/internal/convert/float32_test.go index 2666099d3..0eb6441b3 100644 --- a/audio/internal/convert/float32_test.go +++ b/audio/internal/convert/float32_test.go @@ -34,11 +34,11 @@ func randInt16s(n int) []int16 { } func TestFloat32(t *testing.T) { - cases := []struct { - Name string - In []int16 - SkipOnBrowserReason string - }{ + type testCase struct { + Name string + In []int16 + } + cases := []testCase{ { Name: "empty", In: nil, @@ -55,18 +55,17 @@ func TestFloat32(t *testing.T) { Name: "random 256 values", In: randInt16s(256), }, - { - Name: "random 65536 values", - In: randInt16s(65536), - SkipOnBrowserReason: "entropy is not enough on browser to generate random numbers", - }, + } + // On browsers, entropy might not be enough. + if runtime.GOOS != "js" { + cases = append(cases, testCase{ + Name: "random 65536 values", + In: randInt16s(65536), + }) } for _, c := range cases { c := c t.Run(c.Name, func(t *testing.T) { - if runtime.GOOS == "js" && c.SkipOnBrowserReason != "" { - t.Skip(c.SkipOnBrowserReason) - } // Note that unsafe.SliceData is available as of Go 1.20. var in, out []byte if len(c.In) > 0 {