mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-24 18:58:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

graphicsdriver/opengl: Call glFinish before glReadPixels

Browse Source 
It looks like glFlush is not enough at least on Travis CI.

Fixes #814
This commit is contained in:
Hajime Hoshi 2019-02-14 01:36:21 +09:00
parent 0546783ad5
commit 04dc1faa9c
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/graphicsdriver/opengl/context_desktop.go
View File

@ -161,7 +161,10 @@ func (c *context) bindFramebufferImpl(f framebufferNative) {
func (c *context) framebufferPixels(f *framebuffer, width, height int) ([]byte, error) {
var pixels []byte
_ = mainthread.Run(func() error {
gl.Flush()
// glFlush is not enough. glFinish can be required before glReadPixels on some environments like
// Travis CI (#814)
// See also: https://forums.khronos.org/showthread.php/62741
gl.Finish()
return nil
})
c.bindFramebuffer(f.native)

2
internal/graphicsdriver/opengl/context_mobile.go
View File

@ -142,7 +142,7 @@ func (c *context) bindFramebufferImpl(f framebufferNative) {
func (c *context) framebufferPixels(f *framebuffer, width, height int) ([]byte, error) {
gl := c.gl
gl.Flush()
gl.Finish()
c.bindFramebuffer(f.native)