mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-24 10:48:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

buffered: Avoid creating func objects whenever possible

Browse Source 
Fixes #1220
This commit is contained in:
Hajime Hoshi 2020-06-29 21:45:57 +09:00
parent dea3785750
commit 09322dfdc8
2 changed files with 60 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
internal/buffered/command.go
View File

@ -64,16 +64,14 @@ func getDelayedFuncsAndClearSlow() []func() error {
return nil
}
func tryAddDelayedCommand(f func(obj interface{}) error, ondelayed func() interface{}) bool {
if atomic.LoadUint32(&delayedCommandsFlushed) == 0 {
// Outline the slow-path to expect the fast-path is inlined.
return tryAddDelayedCommandSlow(f, ondelayed)
}
return false
// maybeCanAddDelayedCommand returns false if the delayed commands cannot be added.
// Otherwise, maybeCanAddDelayedCommand's returning value is not determined.
// For example, maybeCanAddDelayedCommand can return true even when flusing is being processed.
func maybeCanAddDelayedCommand() bool {
return atomic.LoadUint32(&delayedCommandsFlushed) == 0
}
func tryAddDelayedCommandSlow(f func(obj interface{}) error, ondelayed func() interface{}) bool {
func tryAddDelayedCommand(f func(obj interface{}) error, ondelayed func() interface{}) bool {
delayedCommandsM.Lock()
defer delayedCommandsM.Unlock()

94
internal/buffered/image.go
View File

@ -55,11 +55,13 @@ func NewImage(width, height int, volatile bool) *Image {
}
func (i *Image) initialize(width, height int, volatile bool) {
if tryAddDelayedCommand(func(obj interface{}) error {
i.initialize(width, height, volatile)
return nil
}, nil) {
return
if maybeCanAddDelayedCommand() {
if tryAddDelayedCommand(func(obj interface{}) error {
i.initialize(width, height, volatile)
return nil
}, nil) {
return
}
}
i.img = mipmap.New(width, height, volatile)
i.width = width
@ -73,11 +75,13 @@ func NewScreenFramebufferImage(width, height int) *Image {
}
func (i *Image) initializeAsScreenFramebuffer(width, height int) {
if tryAddDelayedCommand(func(obj interface{}) error {
i.initializeAsScreenFramebuffer(width, height)
return nil
}, nil) {
return
if maybeCanAddDelayedCommand() {
if tryAddDelayedCommand(func(obj interface{}) error {
i.initializeAsScreenFramebuffer(width, height)
return nil
}, nil) {
return
}
}
i.img = mipmap.NewScreenFramebufferMipmap(width, height)
@ -114,11 +118,13 @@ func (i *Image) resolvePendingFill() {
}
func (i *Image) MarkDisposed() {
if tryAddDelayedCommand(func(obj interface{}) error {
i.MarkDisposed()
return nil
}, nil) {
return
if maybeCanAddDelayedCommand() {
if tryAddDelayedCommand(func(obj interface{}) error {
i.MarkDisposed()
return nil
}, nil) {
return
}
}
i.invalidatePendingPixels()
i.img.MarkDisposed()
@ -165,11 +171,13 @@ func (i *Image) Dump(name string, blackbg bool) error {
}
func (i *Image) Fill(clr color.RGBA) {
if tryAddDelayedCommand(func(obj interface{}) error {
i.Fill(clr)
return nil
}, nil) {
return
if maybeCanAddDelayedCommand() {
if tryAddDelayedCommand(func(obj interface{}) error {
i.Fill(clr)
return nil
}, nil) {
return
}
}
// Defer filling the image so that successive fillings will be merged into one (#1134).
@ -183,15 +191,17 @@ func (i *Image) ReplacePixels(pix []byte, x, y, width, height int) error {
panic(fmt.Sprintf("buffered: len(pix) was %d but must be %d", len(pix), l))
}
if tryAddDelayedCommand(func(copied interface{}) error {
i.ReplacePixels(copied.([]byte), x, y, width, height)
return nil
}, func() interface{} {
copied := make([]byte, len(pix))
copy(copied, pix)
return copied
}) {
return nil
if maybeCanAddDelayedCommand() {
if tryAddDelayedCommand(func(copied interface{}) error {
i.ReplacePixels(copied.([]byte), x, y, width, height)
return nil
}, func() interface{} {
copied := make([]byte, len(pix))
copy(copied, pix)
return copied
}) {
return nil
}
}
if x == 0 && y == 0 && width == i.width && height == i.height {
@ -238,11 +248,13 @@ func (i *Image) DrawImage(src *Image, bounds image.Rectangle, a, b, c, d, tx, ty
Ty: ty,
}
if tryAddDelayedCommand(func(obj interface{}) error {
i.drawImage(src, bounds, g, colorm, mode, filter)
return nil
}, nil) {
return
if maybeCanAddDelayedCommand() {
if tryAddDelayedCommand(func(obj interface{}) error {
i.drawImage(src, bounds, g, colorm, mode, filter)
return nil
}, nil) {
return
}
}
i.drawImage(src, bounds, g, colorm, mode, filter)
@ -275,12 +287,14 @@ func (i *Image) DrawTriangles(src *Image, vertices []float32, indices []uint16,
}
}
if tryAddDelayedCommand(func(obj interface{}) error {
// Arguments are not copied. Copying is the caller's responsibility.
i.DrawTriangles(src, vertices, indices, colorm, mode, filter, address, shader, uniforms)
return nil
}, nil) {
return
if maybeCanAddDelayedCommand() {
if tryAddDelayedCommand(func(obj interface{}) error {
// Arguments are not copied. Copying is the caller's responsibility.
i.DrawTriangles(src, vertices, indices, colorm, mode, filter, address, shader, uniforms)
return nil
}, nil) {
return
}
}
for _, src := range srcs {