mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-25 03:08:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/ui: refactoring: simplify the selection of graphics libraries

Browse Source
This commit is contained in:
Hajime Hoshi 2022-03-23 02:17:56 +09:00
parent 7e6e022065
commit 09b0a0ffaf
4 changed files with 64 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
internal/graphicsdriver/metal/graphics_darwin.go
View File

@ -347,15 +347,22 @@ const (
) )
// isMetalAvailable reports whether Metal is available or not. // isMetalAvailable reports whether Metal is available or not.
//
// On old mac devices like iMac 2011, Metal is not supported (#779).
var isMetalAvailable bool var isMetalAvailable bool
func init() { func init() {
if !supportsMetal() {
return
}
// Initialize isMetalAvailable on the main thread. // Initialize isMetalAvailable on the main thread.
// On old mac devices like iMac 2011, Metal is not supported (#779).
// TODO: Is there a better way to check whether Metal is available or not? // TODO: Is there a better way to check whether Metal is available or not?
// It seems OK to call MTLCreateSystemDefaultDevice multiple times, so this should be fine. // It seems OK to call MTLCreateSystemDefaultDevice multiple times, so this should be fine.
_, isMetalAvailable = mtl.CreateSystemDefaultDevice() if _, ok := mtl.CreateSystemDefaultDevice(); !ok {
return
}
isMetalAvailable = true
} }
var theGraphics Graphics var theGraphics Graphics

19
internal/ui/graphics_ios.go → internal/graphicsdriver/metal/graphics_ios.go
View File

@ -12,20 +12,11 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
//go:build ios && !ebitengl && !ebitencbackend //go:build ios
// +build ios,!ebitengl,!ebitencbackend // +build ios
package ui package metal
import ( func supportsMetal() bool {
"github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver" return true
"github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver/metal"
"github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver/opengl"
)
func graphicsDriver() graphicsdriver.Graphics {
if g := metal.Get(); g != nil {
return g
}
return opengl.Get()
} }

43
internal/graphicsdriver/metal/graphics_macos_darwin.go Normal file
View File

@ -0,0 +1,43 @@
// Copyright 2022 The Ebiten Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//go:build !ios
// +build !ios
package metal
// #cgo CFLAGS: -x objective-c
// #cgo LDFLAGS: -framework Foundation
//
// #import <Foundation/Foundation.h>
//
// static int getMacOSMajorVersion() {
// NSOperatingSystemVersion version = [[NSProcessInfo processInfo] operatingSystemVersion];
// return (int)version.majorVersion;
// }
//
// static int getMacOSMinorVersion() {
// NSOperatingSystemVersion version = [[NSProcessInfo processInfo] operatingSystemVersion];
// return (int)version.minorVersion;
// }
import "C"
func supportsMetal() bool {
// On macOS 10.11 El Capitan, there is a rendering issue on Metal (#781).
// Use the OpenGL in macOS 10.11 or older.
if C.getMacOSMajorVersion() <= 10 && C.getMacOSMinorVersion() <= 11 {
return false
}
return true
}

46
internal/ui/graphics_darwin.go
View File

@ -12,56 +12,20 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
//go:build !ios && !ebitengl && !ebitencbackend //go:build !ebitengl && !ebitencbackend
// +build !ios,!ebitengl,!ebitencbackend // +build !ebitengl,!ebitencbackend
package ui package ui
// #cgo CFLAGS: -x objective-c
// #cgo LDFLAGS: -framework Foundation
//
// #import <Foundation/Foundation.h>
//
// static int getMacOSMajorVersion() {
// NSOperatingSystemVersion version = [[NSProcessInfo processInfo] operatingSystemVersion];
// return (int)version.majorVersion;
// }
//
// static int getMacOSMinorVersion() {
// NSOperatingSystemVersion version = [[NSProcessInfo processInfo] operatingSystemVersion];
// return (int)version.minorVersion;
// }
import "C"
import ( import (
"sync"
"github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver" "github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver"
"github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver/metal" "github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver/metal"
"github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver/opengl" "github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver/opengl"
) )
var theGraphics graphicsdriver.Graphics
func supportsMetal() bool {
// On macOS 10.11 El Capitan, there is a rendering issue on Metal (#781).
// Use the OpenGL in macOS 10.11 or older.
if C.getMacOSMajorVersion() <= 10 && C.getMacOSMinorVersion() <= 11 {
return false
}
return metal.Get() != nil
}
var graphicsOnce sync.Once
func graphicsDriver() graphicsdriver.Graphics { func graphicsDriver() graphicsdriver.Graphics {
graphicsOnce.Do(func() { if g := metal.Get(); g != nil {
if supportsMetal() { return g
theGraphics = metal.Get()
return
} }
theGraphics = opengl.Get() return opengl.Get()
})
return theGraphics
} }