From 0ee70df46651bdef9888252fbaf9e95efdc041d2 Mon Sep 17 00:00:00 2001 From: Hajime Hoshi Date: Wed, 19 Aug 2020 22:32:54 +0900 Subject: [PATCH] ebiten: Skip heavy tests even on Wasm Updates #1313 --- image_test.go | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/image_test.go b/image_test.go index 3a214b969..dc11f879e 100644 --- a/image_test.go +++ b/image_test.go @@ -40,18 +40,12 @@ func skipTooSlowTests(t *testing.T) bool { return true } if runtime.GOOS == "js" { - v := runtime.Version() - if m := regexp.MustCompile(`^go(\d+)\.(\d+)`).FindStringSubmatch(v); m != nil { - major, _ := strconv.Atoi(m[1]) - minor, _ := strconv.Atoi(m[2]) - - // In Go1.12, converting JS arrays from/to slices uses TypedArrayOf, and this might allocates - // too many ArrayBuffers. - if major == 1 && minor <= 12 { - t.Skipf("too slow on Go%d.%dWasm", major, minor) - return true - } - } + // In Go1.12, converting JS arrays from/to slices uses TypedArrayOf, and this might allocates too + // many ArrayBuffers. + // + // Even in the latest versions, timeout often happens especially on Windows/Wasm (#1313). + t.Skip("too slow on Wasm") + return true } return false }