mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2025-02-10 01:53:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

graphicscommand: Bug fix: Adjust vertices to avoid jaggy

Browse Source 
If vertices are (almost) half-integer values, adjust them to avoid
jaggy.

Fixes #929.
This commit is contained in:
Hajime Hoshi 2019-08-27 22:33:14 +09:00
parent 22c31da6c1
commit 19103dcfeb
1 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
internal/graphicscommand/command.go
View File

@ -16,6 +16,7 @@ package graphicscommand
import ( import (
"fmt" "fmt"
"math"
"github.com/hajimehoshi/ebiten/internal/affine" "github.com/hajimehoshi/ebiten/internal/affine"
"github.com/hajimehoshi/ebiten/internal/driver" "github.com/hajimehoshi/ebiten/internal/driver"
@ -171,6 +172,10 @@ func (q *commandQueue) Enqueue(command command) {
q.commands = append(q.commands, command) q.commands = append(q.commands, command)
} }
func fract(x float32) float32 {
return x - float32(math.Floor(float64(x)))
}
// Flush flushes the command queue. // Flush flushes the command queue.
func (q *commandQueue) Flush() { func (q *commandQueue) Flush() {
if q.err != nil { if q.err != nil {
@ -184,10 +189,31 @@ func (q *commandQueue) Flush() {
} }
if theGraphicsDriver.HasHighPrecisionFloat() { if theGraphicsDriver.HasHighPrecisionFloat() {
// Adjust texels. const dstAdjustmentFactor = 1.0 / 256.0
const texelAdjustmentFactor = 1.0 / 512.0 const texelAdjustmentFactor = 1.0 / 512.0
for i := 0; i < q.nvertices/graphics.VertexFloatNum; i++ { for i := 0; i < q.nvertices/graphics.VertexFloatNum; i++ {
s := q.srcSizes[i] s := q.srcSizes[i]
// Adjust the destination position to avoid jaggy (#929).
// This is not a perfect solution since texels on a texture can take a position on borders
// which can cause jaggy. But adjusting only edges should work in most cases.
// The ideal solution is to fix shaders, but this makes the applications slow by adding 'if'
// branches.
switch f := fract(vs[i*graphics.VertexFloatNum+0]); {
case 0.5-dstAdjustmentFactor <= f && f < 0.5:
vs[i*graphics.VertexFloatNum+0] -= f - (0.5 - dstAdjustmentFactor)
case 0.5 <= f && f < 0.5+dstAdjustmentFactor:
vs[i*graphics.VertexFloatNum+0] += (0.5 + dstAdjustmentFactor) - f
}
switch f := fract(vs[i*graphics.VertexFloatNum+1]); {
case 0.5-dstAdjustmentFactor <= f && f < 0.5:
vs[i*graphics.VertexFloatNum+1] -= f - (0.5 - dstAdjustmentFactor)
case 0.5 <= f && f < 0.5+dstAdjustmentFactor:
vs[i*graphics.VertexFloatNum+1] += (0.5 + dstAdjustmentFactor) - f
}
// Adjust regions not to violate neighborhoods (#317, #558, #724).
vs[i*graphics.VertexFloatNum+6] -= 1.0 / s.width * texelAdjustmentFactor vs[i*graphics.VertexFloatNum+6] -= 1.0 / s.width * texelAdjustmentFactor
vs[i*graphics.VertexFloatNum+7] -= 1.0 / s.height * texelAdjustmentFactor vs[i*graphics.VertexFloatNum+7] -= 1.0 / s.height * texelAdjustmentFactor
} }