mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-25 11:18:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

uidriver/mobile: Bug fix: Freezing on Pixel 4a by force calling DoWork

Browse Source 
When the two channels don't receive for a while, call DoWork forcibly to avoid
freeze.

In theory, this timeout should not be necessary. However, it looks like this
'select' statement sometimes blocks forever on some Android devices like
Pixel 4(a). Apparently workAvailable sometimes not receives even though there
are queued OpenGL functions. Call DoWork for such case as a symptomatic
treatment.

Calling DoWork without waiting for workAvailable is safe. If there are no tasks,
DoWork should return immediately.

Updates #1322
Fixes #1332
This commit is contained in:
Hajime Hoshi 2020-09-05 17:11:19 +09:00
parent 29c7b7687f
commit 20ccafce4b
1 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
internal/uidriver/mobile/ui.go
View File

@ -18,10 +18,10 @@ package mobile
import ( import (
"fmt" "fmt"
"runtime"
"runtime/debug" "runtime/debug"
"sync" "sync"
"sync/atomic" "sync/atomic"
"time"
"unicode" "unicode"
"golang.org/x/mobile/app" "golang.org/x/mobile/app"
@ -90,16 +90,34 @@ func (u *UserInterface) Update() error {
workAvailable := u.glWorker.WorkAvailable() workAvailable := u.glWorker.WorkAvailable()
for { for {
// When the two channels don't receive for a while, call DoWork forcibly to avoid freeze
// (#1322, #1332).
//
// In theory, this timeout should not be necessary. However, it looks like this 'select'
// statement sometimes blocks forever on some Android devices like Pixel 4(a). Apparently
// workAvailable sometimes not receives even though there are queued OpenGL functions.
// Call DoWork for such case as a symptomatic treatment.
//
// Calling DoWork without waiting for workAvailable is safe. If there are no tasks, DoWork
// should return immediately.
//
// TODO: Fix the root cause. Note that this is pretty hard since e.g., logging affects the
// scheduling and freezing might not happen with logging.
t := time.NewTimer(100 * time.Millisecond)
select { select {
case <-workAvailable: case <-workAvailable:
if !t.Stop() {
<-t.C
}
u.glWorker.DoWork() u.glWorker.DoWork()
// This is a dirty hack to avoid freezing on Pixel 4 (#1322).
// Apprently there is an issue in the usage of Worker in gomobile or gomobile itself.
// At least, freezing doesn't happen with this Gosched.
runtime.Gosched()
case <-renderEndCh: case <-renderEndCh:
if !t.Stop() {
<-t.C
}
return nil return nil
case <-t.C:
u.glWorker.DoWork()
} }
} }
} }