mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-25 11:18:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

shareable: Refactoring

Browse Source
This commit is contained in:
Hajime Hoshi 2021-01-18 00:35:09 +09:00
parent 0c578f1670
commit 34695dc845
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/shareable/export_test.go
View File

@ -14,6 +14,11 @@
package shareable
const (
MaxCountForShare = maxCountForShare
CountForStartSyncing = countForStartSyncing
)
func MakeImagesSharedForTesting() error {
return makeImagesShared()
}

16
internal/shareable/image.go
View File

@ -73,20 +73,16 @@ func resolveDeferred() {
}
}
// MaxCountForShare represents the time duration when the image can become shared.
//
// This value is exported for testing.
const MaxCountForShare = 10
// maxCountForShare represents the time duration when the image can become shared.
const maxCountForShare = 10
// CountForStartSyncing represents the count that the image starts to sync pixels between GPU and CPU.
//
// This value is exported for testing.
const CountForStartSyncing = MaxCountForShare / 2
// countForStartSyncing represents the count that the image starts to sync pixels between GPU and CPU.
const countForStartSyncing = maxCountForShare / 2
func makeImagesShared() error {
for i := range imagesToMakeShared {
i.usedAsSourceCount++
if i.usedAsSourceCount >= CountForStartSyncing && i.syncing == nil {
if i.usedAsSourceCount >= countForStartSyncing && i.syncing == nil {
// Sync the pixel data on CPU and GPU sides explicitly in order not to block this process.
ch, err := i.backend.restorable.Sync()
if err != nil {
@ -94,7 +90,7 @@ func makeImagesShared() error {
}
i.syncing = ch
}
if i.usedAsSourceCount >= MaxCountForShare {
if i.usedAsSourceCount >= maxCountForShare {
// TODO: Instead of waiting for the channel, use select-case and continue the loop if this
// channel is blocking. However, this might make the tests difficult.
<-i.syncing