mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-25 03:08:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/graphicsdriver/directx: bug fix: processtest failures

Browse Source 
The command allocators should be reset only when the frame index was
updated.

Closes #2249
This commit is contained in:
Hajime Hoshi 2022-09-02 12:47:58 +09:00
parent 1762869791
commit 37bae461d1
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/graphicsdriver/directx/graphics_windows.go
View File

@ -125,6 +125,7 @@ type Graphics struct {
window windows.HWND window windows.HWND
frameIndex int frameIndex int
prevBeginFrameIndex int
// frameStarted is true since Begin until End with present // frameStarted is true since Begin until End with present
frameStarted bool frameStarted bool
@ -684,6 +685,8 @@ func (g *Graphics) resizeSwapChainDesktop(width, height int) error {
// TODO: Reset 0 on Xbox // TODO: Reset 0 on Xbox
g.frameIndex = int(g.swapChain.GetCurrentBackBufferIndex()) g.frameIndex = int(g.swapChain.GetCurrentBackBufferIndex())
// TODO: Are these resetting necessary?
if err := g.drawCommandAllocators[g.frameIndex].Reset(); err != nil { if err := g.drawCommandAllocators[g.frameIndex].Reset(); err != nil {
return err return err
} }
@ -741,14 +744,17 @@ func (g *Graphics) Begin() error {
} }
g.frameStarted = true g.frameStarted = true
if g.prevBeginFrameIndex != g.frameIndex {
if err := g.drawCommandAllocators[g.frameIndex].Reset(); err != nil { if err := g.drawCommandAllocators[g.frameIndex].Reset(); err != nil {
return err return err
} }
if err := g.drawCommandList.Reset(g.drawCommandAllocators[g.frameIndex], nil); err != nil { if err := g.copyCommandAllocators[g.frameIndex].Reset(); err != nil {
return err return err
} }
}
g.prevBeginFrameIndex = g.frameIndex
if err := g.copyCommandAllocators[g.frameIndex].Reset(); err != nil { if err := g.drawCommandList.Reset(g.drawCommandAllocators[g.frameIndex], nil); err != nil {
return err return err
} }
if err := g.copyCommandList.Reset(g.copyCommandAllocators[g.frameIndex], nil); err != nil { if err := g.copyCommandList.Reset(g.copyCommandAllocators[g.frameIndex], nil); err != nil {