mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-11-10 04:57:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

ebiten: update comments

Browse Source 
Updates #2601
This commit is contained in:
Hajime Hoshi 2023-03-14 13:06:11 +09:00
parent b1048025d9
commit 39aaf7fe37
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
image.go
View File

@ -38,10 +38,10 @@ type Image struct {
original *Image original *Image
bounds image.Rectangle bounds image.Rectangle
// tmpVertices must not be reused until the vertices are sent to the graphics command queue. // tmpVertices must not be reused until ui.Image.Draw* is called.
tmpVertices []float32 tmpVertices []float32
// tmpUniforms must not be reused until the vertices are sent to the graphics command queue. // tmpUniforms must not be reused until ui.Image.Draw* is called.
tmpUniforms []uint32 tmpUniforms []uint32
// Do not add a 'buffering' member that are resolved lazily. // Do not add a 'buffering' member that are resolved lazily.

3
internal/graphicscommand/command.go
View File

@ -110,6 +110,9 @@ func (q *commandQueue) EnqueueDrawTrianglesCommand(dst *Image, srcs [graphics.Sh
q.tmpNumVertexFloats += len(vertices) q.tmpNumVertexFloats += len(vertices)
q.tmpNumIndices += len(indices) q.tmpNumIndices += len(indices)
// prependPreservedUniforms not only prepends values to the given slice but also creates a new slice.
// Allocating a new slice is necessary to make EnqueueDrawTrianglesCommand safe so far.
// TODO: This might cause a performance issue (#2601).
uniforms = q.prependPreservedUniforms(uniforms, shader, dst, srcs, offsets, dstRegion, srcRegion) uniforms = q.prependPreservedUniforms(uniforms, shader, dst, srcs, offsets, dstRegion, srcRegion)
// Remove unused uniform variables so that more commands can be merged. // Remove unused uniform variables so that more commands can be merged.