mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-24 10:48:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

graphics: Stop unnecessary copy of elements

Browse Source
This commit is contained in:
Hajime Hoshi 2018-02-20 01:17:21 +09:00
parent f1f7e5bcec
commit 40b1948baa
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/affine/colorm.go
View File

@ -44,7 +44,7 @@ var (
// The initial value is identity.
type ColorM struct {
// When elements is nil, this matrix is identity.
// elements is immutable and a new array must be created when updating.
// elements are immutable and a new array must be created when updating.
body []float32
translate []float32
}

6
internal/graphics/program.go
View File

@ -271,14 +271,16 @@ func (s *openGLState) useProgram(proj []float32, texture opengl.Texture, sourceW
if s.lastColorMatrix == nil {
s.lastColorMatrix = make([]float32, 16)
}
copy(s.lastColorMatrix, esBody)
// ColorM's elements are immutable. It's OK to hold the reference without copying.
s.lastColorMatrix = esBody
}
if !areSameFloat32Array(s.lastColorMatrixTranslation, esTranslate) {
c.UniformFloats(program, "color_matrix_translation", esTranslate)
if s.lastColorMatrixTranslation == nil {
s.lastColorMatrixTranslation = make([]float32, 4)
}
copy(s.lastColorMatrixTranslation, esTranslate)
// ColorM's elements are immutable. It's OK to hold the reference without copying.
s.lastColorMatrixTranslation = esTranslate
}
if program == s.programLinear {