mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-27 04:08:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

ebiten: Avoid unnecessary creations of c.screen

Browse Source 
Updates #1884
This commit is contained in:
Hajime Hoshi 2021-11-27 18:19:06 +09:00
parent e6f2764d08
commit 42c1427c0b
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
uicontext.go
View File

@ -68,37 +68,42 @@ func (c *uiContext) Layout(outsideWidth, outsideHeight float64) {
} }
func (c *uiContext) updateOffscreen() { func (c *uiContext) updateOffscreen() {
sw, sh := c.game.Layout(int(c.outsideWidth), int(c.outsideHeight)) ow, oh := c.game.Layout(int(c.outsideWidth), int(c.outsideHeight))
if sw <= 0 || sh <= 0 { if ow <= 0 || oh <= 0 {
panic("ebiten: Layout must return positive numbers") panic("ebiten: Layout must return positive numbers")
} }
// TODO: This is duplicated with mobile/ebitenmobileview/funcs.go. Refactor this.
d := uiDriver().DeviceScaleFactor()
sw, sh := int(c.outsideWidth*d), int(c.outsideHeight*d)
if c.offscreen != nil && !c.outsideSizeUpdated { if c.offscreen != nil && !c.outsideSizeUpdated {
if w, h := c.offscreen.Size(); w == sw && h == sh { if w, h := c.offscreen.Size(); w == ow && h == oh {
return return
} }
} }
c.outsideSizeUpdated = false c.outsideSizeUpdated = false
if c.screen != nil { if c.screen != nil {
if w, h := c.screen.Size(); w != sw || h != sh {
c.screen.Dispose() c.screen.Dispose()
c.screen = nil c.screen = nil
} }
}
if c.screen == nil {
c.screen = newScreenFramebufferImage(int(c.outsideWidth*d), int(c.outsideHeight*d))
}
if c.offscreen != nil { if c.offscreen != nil {
if w, h := c.offscreen.Size(); w != sw || h != sh { if w, h := c.offscreen.Size(); w != ow || h != oh {
c.offscreen.Dispose() c.offscreen.Dispose()
c.offscreen = nil c.offscreen = nil
} }
} }
if c.offscreen == nil { if c.offscreen == nil {
c.offscreen = NewImage(sw, sh) c.offscreen = NewImage(ow, oh)
c.offscreen.mipmap.SetVolatile(IsScreenClearedEveryFrame()) c.offscreen.mipmap.SetVolatile(IsScreenClearedEveryFrame())
} }
// TODO: This is duplicated with mobile/ebitenmobileview/funcs.go. Refactor this.
d := uiDriver().DeviceScaleFactor()
c.screen = newScreenFramebufferImage(int(c.outsideWidth*d), int(c.outsideHeight*d))
} }
func (c *uiContext) setScreenClearedEveryFrame(cleared bool) { func (c *uiContext) setScreenClearedEveryFrame(cleared bool) {