mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-26 03:38:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/buffered: skip a flaky test

Browse Source 
Updates #2805
This commit is contained in:
Hajime Hoshi 2023-10-10 01:03:31 +09:00
parent cc5174f104
commit 4701a61e4b
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
internal/buffered/image_test.go
View File

@ -19,6 +19,7 @@ import (
"os" "os"
"runtime" "runtime"
"testing" "testing"
"time"
"github.com/hajimehoshi/ebiten/v2" "github.com/hajimehoshi/ebiten/v2"
"github.com/hajimehoshi/ebiten/v2/internal/atlas" "github.com/hajimehoshi/ebiten/v2/internal/atlas"
@ -307,18 +308,27 @@ func TestWritePixelsAndModifyBeforeMain(t *testing.T) {
} }
} }
var isImageGCed bool var imageGCedCh = make(chan struct{})
func init() { func init() {
img := buffered.NewImage(1, 1, atlas.ImageTypeRegular) img := buffered.NewImage(1, 1, atlas.ImageTypeRegular)
runtime.SetFinalizer(img, func(*buffered.Image) { runtime.SetFinalizer(img, func(*buffered.Image) {
isImageGCed = true close(imageGCedCh)
}) })
} }
func TestGC(t *testing.T) { func TestGC(t *testing.T) {
t.Skip("flaky (especially on GitHub Actions)")
runtime.GC() runtime.GC()
if !isImageGCed { runtime.GC()
// A finalizer should be called eventually, but this might not be immediate.
// Set a time out.
select {
case <-imageGCedCh:
return
case <-time.After(time.Second):
t.Error("an image in init() must be GCed but not") t.Error("an image in init() must be GCed but not")
} }
} }