From 4b7064ac58ba731239083f7c471490abf556570a Mon Sep 17 00:00:00 2001
From: Hajime Hoshi <hajimehoshi@gmail.com>
Date: Sat, 10 Jul 2021 19:21:27 +0900
Subject: [PATCH] audio: Bug fix: Do not create players every call of IsReady

Close #1709
---
 audio/audio.go | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/audio/audio.go b/audio/audio.go
index 05f99998a..f10572b7c 100644
--- a/audio/audio.go
+++ b/audio/audio.go
@@ -71,6 +71,7 @@ type Context struct {
 	sampleRate int
 	err        error
 	ready      bool
+	readyOnce  sync.Once
 
 	players map[playerImpl]struct{}
 
@@ -255,15 +256,18 @@ func (c *Context) IsReady() bool {
 		return r
 	}
 
-	// Create another goroutine since (*Player).Play can lock the context's mutex.
-	go func() {
-		// The audio context is never ready unless there is a player. This is
-		// problematic when a user tries to play audio after the context is ready.
-		// Play a dummy player to avoid the blocking (#969).
-		// Use a long enough buffer so that writing doesn't finish immediately (#970).
-		p := NewPlayerFromBytes(c, make([]byte, bufferSize()*2))
-		p.Play()
-	}()
+	c.readyOnce.Do(func() {
+		// Create another goroutine since (*Player).Play can lock the context's mutex.
+		// TODO: Is this needed for reader players?
+		go func() {
+			// The audio context is never ready unless there is a player. This is
+			// problematic when a user tries to play audio after the context is ready.
+			// Play a dummy player to avoid the blocking (#969).
+			// Use a long enough buffer so that writing doesn't finish immediately (#970).
+			p := NewPlayerFromBytes(c, make([]byte, bufferSize()*2))
+			p.Play()
+		}()
+	})
 
 	return r
 }