mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2025-01-23 17:32:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/graphicscommand: disable asynchronous rendering when vsync is on

Browse Source 
Asynchronouse rendering was introduced at #2664, but apparently this
caused a delay between a game's update and its rendering.

Disable this when vsync is on. When vsync is off, we should not have
to care the delay since new renderings keep to come. Rather,
asynchronous renderings improves FPS.

Updates #2664
Updates #2822
This commit is contained in:
Hajime Hoshi 2023-10-28 14:19:37 +09:00
parent 98f2798b07
commit 6339872da8
2 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
internal/graphicscommand/commandqueue.go
View File

@ -27,6 +27,16 @@ import (
"github.com/hajimehoshi/ebiten/v2/internal/shaderir"
)
var vsyncEnabled int32 = 1
func SetVsyncEnabled(enabled bool) {
if enabled {
atomic.StoreInt32(&vsyncEnabled, 1)
} else {
atomic.StoreInt32(&vsyncEnabled, 0)
}
}
// FlushCommands flushes the command queue and present the screen if needed.
// If endFrame is true, the current screen might be used to present.
func FlushCommands(graphicsDriver graphicsdriver.Graphics, endFrame bool, swapBuffersForGL func()) error {
@ -154,10 +164,16 @@ func (q *commandQueue) Flush(graphicsDriver graphicsdriver.Graphics, endFrame bo
}
var sync bool
for _, c := range q.commands {
if c.NeedsSync() {
sync = true
break
// Disable asynchrnous rendering when vsync is on, as this causes a rendering delay (#2822).
if endFrame && atomic.LoadInt32(&vsyncEnabled) != 0 {
sync = true
}
if !sync {
for _, c := range q.commands {
if c.NeedsSync() {
sync = true
break
}
}
}

5
internal/ui/ui_glfw.go
View File

@ -30,6 +30,7 @@ import (
"github.com/hajimehoshi/ebiten/v2/internal/file"
"github.com/hajimehoshi/ebiten/v2/internal/gamepad"
"github.com/hajimehoshi/ebiten/v2/internal/glfw"
"github.com/hajimehoshi/ebiten/v2/internal/graphicscommand"
"github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver"
"github.com/hajimehoshi/ebiten/v2/internal/hook"
"github.com/hajimehoshi/ebiten/v2/internal/microsoftgdk"
@ -1317,8 +1318,10 @@ func (u *UserInterface) setFPSMode(fpsMode FPSModeType) error {
return err
}
vsyncEnabled := u.fpsMode == FPSModeVsyncOn
graphicscommand.SetVsyncEnabled(vsyncEnabled)
u.renderThread.CallAsync(func() {
u.graphicsDriver.SetVsyncEnabled(u.fpsMode == FPSModeVsyncOn)
u.graphicsDriver.SetVsyncEnabled(vsyncEnabled)
})
return nil