mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2025-01-13 20:42:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

shareable: Bug fix: Double free

Browse Source
This commit is contained in:
Hajime Hoshi 2018-07-22 05:52:11 +09:00
parent 6687ffe8ba
commit 693116ffd6
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/shareable/shareable.go
View File

@ -156,6 +156,9 @@ func (i *Image) forceShared() {
newI.replacePixels(pixels) newI.replacePixels(pixels)
i.dispose(false) i.dispose(false)
*i = *newI *i = *newI
// TODO: This is a very tricky hack not to call Dispose twice for the same backend.
// Avoid such hack.
runtime.SetFinalizer(newI, nil)
} }
func (i *Image) region() (x, y, width, height int) { func (i *Image) region() (x, y, width, height int) {

3
internal/shareable/shareable_test.go
View File

@ -18,6 +18,7 @@ import (
"errors" "errors"
"image/color" "image/color"
"os" "os"
"runtime"
"testing" "testing"
"github.com/hajimehoshi/ebiten" "github.com/hajimehoshi/ebiten"
@ -183,4 +184,6 @@ func TestReshared(t *testing.T) {
} }
} }
} }
runtime.GC()
} }