From 6d714a16cfe60599f617ebd3f092dff1a4853ceb Mon Sep 17 00:00:00 2001 From: Hajime Hoshi Date: Thu, 10 Jan 2019 01:37:11 +0900 Subject: [PATCH] audio: Remove unneeded 'break' --- audio/audio.go | 1 - audio/mux.go | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/audio/audio.go b/audio/audio.go index 16b5aa873..91c213f40 100644 --- a/audio/audio.go +++ b/audio/audio.go @@ -437,7 +437,6 @@ func (p *playerImpl) readLoop() { } timer = time.NewTimer(time.Millisecond) timerCh = timer.C - break case <-timerCh: // If the buffer has 1 second, that's enough. diff --git a/audio/mux.go b/audio/mux.go index 830cfa1e4..6cff9f2d2 100644 --- a/audio/mux.go +++ b/audio/mux.go @@ -55,6 +55,8 @@ func (m *mux) Read(b []byte) (int, error) { allSkipped := true + // TODO: Now a player is not locked. Should we lock it? + for p := range m.ps { if p.shouldSkip() { continue