audio: Bug fix: Race condition on accessing the set of players

Closes #1548

audio/audio.go

@@ -148,19 +148,7 @@ func NewContext(sampleRate int) *Context {
 			return err
 		}
 
-		// Now reader players cannot call removePlayers from themselves in the current implementation.
+		c.gcPlayers()
-		// Underlying playering can be the pause state after fishing its playing,
-		// but there is no way to notify this to readerPlayers so far.
-		// Instead, let's check the states proactively every frame.
-		for p := range c.players {
-			rp, ok := p.(*readerPlayer)
-			if !ok {
-				break
-			}
-			if !rp.IsPlaying() {
-				delete(c.players, p)
-			}
-		}
 		return nil
 	})
 
@@ -217,6 +205,25 @@ func (c *Context) removePlayer(p playerImpl) {
 	c.m.Unlock()
 }
 
+func (c *Context) gcPlayers() {
+	c.m.Lock()
+	defer c.m.Unlock()
+
+	// Now reader players cannot call removePlayers from themselves in the current implementation.
+	// Underlying playering can be the pause state after fishing its playing,
+	// but there is no way to notify this to readerPlayers so far.
+	// Instead, let's check the states proactively every frame.
+	for p := range c.players {
+		rp, ok := p.(*readerPlayer)
+		if !ok {
+			return
+		}
+		if !rp.IsPlaying() {
+			delete(c.players, p)
+		}
+	}
+}
+
 // IsReady returns a boolean value indicating whether the audio is ready or not.
 //
 // On some browsers, user interaction like click or pressing keys is required to start audio.