mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2025-01-12 12:08:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

restorable: Use DrawTriangles to restore the image

Browse Source 
This can avoid allocating a big byte slice.
This commit is contained in:
Hajime Hoshi 2019-07-15 04:51:33 +09:00
parent 7e4e9cc893
commit 84aabd075f
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
internal/restorable/image.go
View File

@ -191,11 +191,9 @@ func (i *Image) clearForInitialization() {
i.fill(0, 0, 0, 0) i.fill(0, 0, 0, 0)
} }
func (i *Image) fill(r, g, b, a byte) { // fillImage fills a graphicscommand.Image with the specified color.
if i.priority { // This does nothing to do with a restorable.Image's rendering state.
panic("restorable: clear cannot be called on a priority image") func fillImage(img *graphicscommand.Image, r, g, b, a byte) {
}
rf := float32(0) rf := float32(0)
gf := float32(0) gf := float32(0)
bf := float32(0) bf := float32(0)
@ -212,7 +210,7 @@ func (i *Image) fill(r, g, b, a byte) {
// The rendering target size needs to be its 'internal' size instead of the exposed size to avoid glitches on // The rendering target size needs to be its 'internal' size instead of the exposed size to avoid glitches on
// mobile platforms (See the change 1e1f309a). // mobile platforms (See the change 1e1f309a).
dw, dh := i.internalSize() dw, dh := img.InternalSize()
sw, sh := emptyImage.Size() sw, sh := emptyImage.Size()
vs := make([]float32, 4*graphics.VertexFloatNum) vs := make([]float32, 4*graphics.VertexFloatNum)
graphics.PutQuadVertices(vs, emptyImage, 0, 0, sw, sh, graphics.PutQuadVertices(vs, emptyImage, 0, 0, sw, sh,
@ -221,9 +219,19 @@ func (i *Image) fill(r, g, b, a byte) {
is := graphics.QuadIndices() is := graphics.QuadIndices()
c := driver.CompositeModeCopy c := driver.CompositeModeCopy
if a == 0 { if a == 0 {
// The first DrawTriangles must be clear mode for initialization.
// TODO: Can the graphicscommand package hide this knowledge?
c = driver.CompositeModeClear c = driver.CompositeModeClear
} }
i.image.DrawTriangles(emptyImage.image, vs, is, nil, c, driver.FilterNearest, driver.AddressClampToZero) img.DrawTriangles(emptyImage.image, vs, is, nil, c, driver.FilterNearest, driver.AddressClampToZero)
}
func (i *Image) fill(r, g, b, a byte) {
if i.priority {
panic("restorable: clear cannot be called on a priority image")
}
fillImage(i.image, r, g, b, a)
w, h := i.Size() w, h := i.Size()
i.basePixels = &Pixels{ i.basePixels = &Pixels{
@ -533,8 +541,7 @@ func (i *Image) restore() error {
gimg.ReplacePixels(i.basePixels.Slice(), 0, 0, w, h) gimg.ReplacePixels(i.basePixels.Slice(), 0, 0, w, h)
} else { } else {
// Clear the image explicitly. // Clear the image explicitly.
pix := make([]byte, w*h*4) fillImage(gimg, 0, 0, 0, 0)
gimg.ReplacePixels(pix, 0, 0, w, h)
} }
for _, c := range i.drawTrianglesHistory { for _, c := range i.drawTrianglesHistory {
if c.image.hasDependency() { if c.image.hasDependency() {