mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-09-20 05:12:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

graphics: Allow ReplacePixels on a sub-image

Browse Source 
Fixes #980
This commit is contained in:
Hajime Hoshi 2020-02-16 22:16:27 +09:00
parent d9bd7ab07d
commit 875a529708
3 changed files with 53 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
image.go
View File

@ -472,12 +472,8 @@ func (i *Image) ReplacePixels(p []byte) error {
if i.isDisposed() {
return nil
}
// TODO: Implement this.
if i.isSubImage() {
panic("ebiten: render to a subimage is not implemented (ReplacePixels)")
}
s := i.Bounds().Size()
if err := i.buffered.ReplacePixels(p, 0, 0, s.X, s.Y); err != nil {
r := i.Bounds()
if err := i.buffered.ReplacePixels(p, r.Min.X, r.Min.Y, r.Dx(), r.Dy()); err != nil {
theUIContext.setError(err)
}
return nil

50
image_test.go
View File

@ -1852,3 +1852,53 @@ func TestImageDrawTrianglesAndMutateArgs(t *testing.T) {
}
}
}
func TestImageReplacePixelsOnSubImage(t *testing.T) {
dst, _ := NewImage(17, 31, FilterDefault)
dst.Fill(color.RGBA{0xff, 0, 0, 0xff})
pix0 := make([]byte, 4*5*3)
idx := 0
for j := 0; j < 3; j++ {
for i := 0; i < 5; i++ {
pix0[4*idx] = 0
pix0[4*idx+1] = 0xff
pix0[4*idx+2] = 0
pix0[4*idx+3] = 0xff
idx++
}
}
r0 := image.Rect(4, 5, 9, 8)
dst.SubImage(r0).(*Image).ReplacePixels(pix0)
pix1 := make([]byte, 4*5*3)
idx = 0
for j := 0; j < 3; j++ {
for i := 0; i < 5; i++ {
pix1[4*idx] = 0
pix1[4*idx+1] = 0
pix1[4*idx+2] = 0xff
pix1[4*idx+3] = 0xff
idx++
}
}
r1 := image.Rect(11, 10, 16, 13)
dst.SubImage(r1).(*Image).ReplacePixels(pix1)
for j := 0; j < 31; j++ {
for i := 0; i < 17; i++ {
got := dst.At(i, j).(color.RGBA)
want := color.RGBA{0xff, 0, 0, 0xff}
p := image.Pt(i, j)
switch {
case p.In(r0):
want = color.RGBA{0, 0xff, 0, 0xff}
case p.In(r1):
want = color.RGBA{0, 0, 0xff, 0xff}
}
if got != want {
t.Errorf("dst.At(%d, %d): got: %v, want: %v", i, j, got, want)
}
}
}
}

1
internal/buffered/image.go
View File

@ -181,6 +181,7 @@ func (i *Image) ReplacePixels(pix []byte, x, y, width, height int) error {
return nil
}
// TODO: Can we use (*restorable.Image).ReplacePixels?
if i.pixels == nil {
pix := make([]byte, 4*i.width*i.height)
idx := 0