mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-11-13 22:47:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/restorable: Remove needsDisposingWhenRestoring

Browse Source 
Now restoring from context lost doesn't work on browsers. Then,
the constant needsDisposingWhenRestoring is actually always true.
This commit is contained in:
Hajime Hoshi 2021-10-23 23:46:26 +09:00
parent dddfe73604
commit 96dc80fd08
4 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/restorable/const_gles.go
View File

@ -17,6 +17,4 @@
package restorable package restorable
const needsDisposingWhenRestoring = true
const canDetectContextLostExplicitly = true const canDetectContextLostExplicitly = true

6
internal/restorable/const_js.go
View File

@ -14,11 +14,5 @@
package restorable package restorable
// needsDisposingWhenRestoring reports whether disposing resources is necessary or not when restoring.
//
// On browsers, disposing resources is not required since the objects are already managed by JavaScript GC and they
// are already invalidated. Rather, disposing them when restoring causes warnings on the console.
const needsDisposingWhenRestoring = false
// canDetectContextLostExplicitly reports whether the context lost can be detected by handlers in an explicit way. // canDetectContextLostExplicitly reports whether the context lost can be detected by handlers in an explicit way.
const canDetectContextLostExplicitly = true const canDetectContextLostExplicitly = true

2
internal/restorable/const_others.go
View File

@ -19,6 +19,4 @@
package restorable package restorable
const needsDisposingWhenRestoring = true
const canDetectContextLostExplicitly = false const canDetectContextLostExplicitly = false

4
internal/restorable/images.go
View File

@ -201,9 +201,7 @@ func (i *images) restore() error {
// Dispose all the shaders ahead of restoring. A current shader ID and a new shader ID can be duplicated. // Dispose all the shaders ahead of restoring. A current shader ID and a new shader ID can be duplicated.
for s := range i.shaders { for s := range i.shaders {
if needsDisposingWhenRestoring {
s.shader.Dispose() s.shader.Dispose()
}
s.shader = nil s.shader = nil
} }
for s := range i.shaders { for s := range i.shaders {
@ -213,9 +211,7 @@ func (i *images) restore() error {
// Dispose all the images ahead of restoring. A current texture ID and a new texture ID can be duplicated. // Dispose all the images ahead of restoring. A current texture ID and a new texture ID can be duplicated.
// TODO: Write a test to confirm that ID duplication never happens. // TODO: Write a test to confirm that ID duplication never happens.
for i := range i.images { for i := range i.images {
if needsDisposingWhenRestoring {
i.image.Dispose() i.image.Dispose()
}
i.image = nil i.image = nil
} }