mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-26 03:38:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

audio: refactoring

Browse Source
This commit is contained in:
Hajime Hoshi 2023-07-30 14:42:13 +09:00
parent b580d0f016
commit 9b05d9eb35
3 changed files with 1 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
audio/audio.go
View File

@ -240,7 +240,7 @@ func (c *Context) IsReady() bool {
// problematic when a user tries to play audio after the context is ready. // problematic when a user tries to play audio after the context is ready.
// Play a dummy player to avoid the blocking (#969). // Play a dummy player to avoid the blocking (#969).
// Use a long enough buffer so that writing doesn't finish immediately (#970). // Use a long enough buffer so that writing doesn't finish immediately (#970).
p := NewPlayerFromBytes(c, make([]byte, bufferSize()*2)) p := NewPlayerFromBytes(c, make([]byte, 16384))
p.Play() p.Play()
}() }()
}) })

23
audio/buffersize_mobile.go
View File

@ -1,23 +0,0 @@
// Copyright 2018 The Ebiten Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//go:build android || ios
package audio
func bufferSize() int {
// From the experience of Daigo's games (e.g. Clock of Atonement),
// 8192 is not enough on mobile devices. Use x1.5 value.
return 12288
}

23
audio/buffersize_notmobile.go
View File

@ -1,23 +0,0 @@
// Copyright 2018 The Ebiten Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//go:build !android && !ios
package audio
func bufferSize() int {
// On most desktop environments, 4096 [bytes] is enough
// but there are some known environment that is too short (e.g. Windows on Parallels).
return 8192
}