mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2025-01-24 01:42:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

ebiten: update image.DrawTriangles* to re-use indices (#3026)

Browse Source 
Reduces allocations and GC overhead for programs that
call this method hundreds of times per rendered frame.
This commit is contained in:
Ernest Romero Climent 2024-07-02 00:40:53 -07:00 committed by GitHub
parent e3af35e6ff
commit 9d4f88c992
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
image.go
View File

@ -43,6 +43,9 @@ type Image struct {
// tmpVertices must not be reused until ui.Image.Draw* is called. // tmpVertices must not be reused until ui.Image.Draw* is called.
tmpVertices []float32 tmpVertices []float32
// tmpIndices must not be reused until ui.Image.Draw* is called.
tmpIndices []uint32
// tmpUniforms must not be reused until ui.Image.Draw* is called. // tmpUniforms must not be reused until ui.Image.Draw* is called.
tmpUniforms []uint32 tmpUniforms []uint32
@ -514,7 +517,7 @@ func (i *Image) DrawTriangles(vertices []Vertex, indices []uint16, img *Image, o
vs[i*graphics.VertexFloatCount+7] = v.ColorA * ca vs[i*graphics.VertexFloatCount+7] = v.ColorA * ca
} }
} }
is := make([]uint32, len(indices)) is := i.ensureTmpIndices(len(indices))
for i := range is { for i := range is {
is[i] = uint32(indices[i]) is[i] = uint32(indices[i])
} }
@ -664,7 +667,7 @@ func (i *Image) DrawTrianglesShader(vertices []Vertex, indices []uint16, shader
vs[i*graphics.VertexFloatCount+7] = v.ColorA vs[i*graphics.VertexFloatCount+7] = v.ColorA
} }
is := make([]uint32, len(indices)) is := i.ensureTmpIndices(len(indices))
for i := range is { for i := range is {
is[i] = uint32(indices[i]) is[i] = uint32(indices[i])
} }
@ -1265,6 +1268,13 @@ func (i *Image) ensureTmpVertices(n int) []float32 {
return i.tmpVertices[:n] return i.tmpVertices[:n]
} }
func (i *Image) ensureTmpIndices(n int) []uint32 {
if cap(i.tmpIndices) < n {
i.tmpIndices = make([]uint32, n)
}
return i.tmpIndices[:n]
}
// private implements FinalScreen. // private implements FinalScreen.
func (*Image) private() { func (*Image) private() {
} }