mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-09-19 21:02:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

graphics: Reland: Bug fix: a too old frame was rendered at least on Android

Browse Source 
Fixes #525
This commit is contained in:
Hajime Hoshi 2018-03-01 23:05:10 +09:00
parent 1c0f5e09d5
commit b8deabbd94
2 changed files with 22 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
graphicscontext.go
View File

@ -16,6 +16,7 @@ package ebiten
import (
"github.com/hajimehoshi/ebiten/internal/clock"
"github.com/hajimehoshi/ebiten/internal/graphics"
"github.com/hajimehoshi/ebiten/internal/hooks"
"github.com/hajimehoshi/ebiten/internal/restorable"
"github.com/hajimehoshi/ebiten/internal/ui"
@ -97,27 +98,31 @@ func (c *graphicsContext) Update(afterFrameUpdate func()) error {
}
afterFrameUpdate()
}
if 0 < updateCount {
// Call ClearFramebuffer instead of c.screen.Clear()
// to clear the whole region including fullscreen's padding.
c.screen.restorable.ClearFramebuffer()
dw, dh := c.screen.Size()
sw, _ := c.offscreen.Size()
scale := float64(dw) / float64(sw)
// Clear the screen framebuffer by DrawImage instad of Fill
// to clear the whole region including fullscreen's padding.
op := &DrawImageOptions{}
w, h := emptyImage.Size()
// graphics.MaxImageSize should be the maximum size of framebuffer.
op.GeoM.Scale(graphics.MaxImageSize/float64(w), graphics.MaxImageSize/float64(h))
op.CompositeMode = CompositeModeCopy
op.Filter = filterScreen // any filter is fine: just use the same filter as below.
c.screen.DrawImage(emptyImage, op)
op := &DrawImageOptions{}
dw, dh := c.screen.Size()
sw, _ := c.offscreen.Size()
scale := float64(dw) / float64(sw)
// c.screen is special: its Y axis is down to up,
// and the origin point is lower left.
op.GeoM.Scale(scale, -scale)
op.GeoM.Translate(0, float64(dh))
op.GeoM.Translate(c.offsetX, c.offsetY)
op = &DrawImageOptions{}
// c.screen is special: its Y axis is down to up,
// and the origin point is lower left.
op.GeoM.Scale(scale, -scale)
op.GeoM.Translate(0, float64(dh))
op.GeoM.Translate(c.offsetX, c.offsetY)
op.CompositeMode = CompositeModeCopy
op.Filter = filterScreen
_ = c.screen.DrawImage(c.offscreen, op)
}
op.CompositeMode = CompositeModeCopy
op.Filter = filterScreen
_ = c.screen.DrawImage(c.offscreen, op)
if err := restorable.ResolveStaleImages(); err != nil {
return err

4
internal/restorable/image.go
View File

@ -129,10 +129,6 @@ func (i *Image) clearIfVolatile() {
if !i.volatile {
return
}
i.ClearFramebuffer()
}
func (i *Image) ClearFramebuffer() {
i.basePixels = nil
i.drawImageHistory = nil
i.stale = false