From cc999a4c5b45f3d00caff464d6ed979a3ec68a3d Mon Sep 17 00:00:00 2001 From: Hajime Hoshi Date: Wed, 4 Oct 2023 13:27:04 +0900 Subject: [PATCH] .github/workflows: skip vettools for Go 1.18 and 1.19 There is an issue in golang.org/x/tools@v0.12.0. See golang/go#62519 for the details. As a temporary solution, just skip using vettools for Go 1.18 and 1.19. --- .github/workflows/test.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3270b5b8d..b65d60fb8 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -66,6 +66,9 @@ jobs: go list ./... | grep -v -x -F -f .github/workflows/govetblock.txt | xargs go vet - name: go vet (vettool) + # Stop vettools for old Go versions. Apparently this is an issue in golang.org/x/tools (golang/go#62519) + # TODO: Update golang.org/x/tools and remove this restriction. + if: ${{ !startsWith(matrix.go, '1.18.') && !startsWith(matrix.go, '1.19.') }} run: | go install ./internal/vettools go vet -vettool=$(which vettools)${{ runner.os == 'Windows' && '.exe' || '' }} -v ./...