mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2025-01-13 04:22:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "internal/atlas: reduce slice allocations"

Browse Source 
This reverts commit 9442b244fc.

Reason: the slice was not escaped to heap, so this optimization was not needed
This commit is contained in:
Hajime Hoshi 2024-05-27 23:46:48 +09:00
parent 9442b244fc
commit d0aaa23005
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/atlas/image.go
View File

@ -256,9 +256,6 @@ type Image struct {
// //
// usedAsDestinationCount is never reset. // usedAsDestinationCount is never reset.
usedAsDestinationCount int usedAsDestinationCount int
// tmpBackends is a temporary slice for ensureIsolatedFromSource.
tmpBackends []*backend
} }
// moveTo moves its content to the given image dst. // moveTo moves its content to the given image dst.
@ -439,7 +436,8 @@ func (i *Image) drawTriangles(srcs [graphics.ShaderImageCount]*Image, vertices [
return return
} }
i.tmpBackends = i.tmpBackends[:0] // This slice is not escaped to the heap. This can be checked by `go build -gcflags=-m`.
backends := make([]*backend, 0, len(srcs))
for _, src := range srcs { for _, src := range srcs {
if src == nil { if src == nil {
continue continue
@ -449,16 +447,11 @@ func (i *Image) drawTriangles(srcs [graphics.ShaderImageCount]*Image, vertices [
// If the backend becomes the same as i's, i's backend will be changed at ensureIsolatedFromSource. // If the backend becomes the same as i's, i's backend will be changed at ensureIsolatedFromSource.
src.allocate(nil, true) src.allocate(nil, true)
} }
i.tmpBackends = append(i.tmpBackends, src.backend) backends = append(backends, src.backend)
src.backend.sourceInThisFrame = true src.backend.sourceInThisFrame = true
} }
i.ensureIsolatedFromSource(i.tmpBackends) i.ensureIsolatedFromSource(backends)
for idx := range i.tmpBackends {
i.tmpBackends[idx] = nil
}
i.tmpBackends = i.tmpBackends[:0]
for _, src := range srcs { for _, src := range srcs {
// Compare i and source images after ensuring i is not on an atlas, or // Compare i and source images after ensuring i is not on an atlas, or