mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-11-10 04:57:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/graphicscommand: bug fix: flush image buffers

Browse Source 
This is basically a revert for 4d5b608d0c.
This caused a crash on Windows.

Even after this fix, the browser tests seem no longer flaky, but
I am not 100% sure.

Updates #2391
Closes #2423
This commit is contained in:
Hajime Hoshi 2022-10-30 02:20:44 +09:00
parent f89f99a2bc
commit d6910eb9ab
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/graphicscommand/command.go
View File

@ -250,13 +250,7 @@ func (q *commandQueue) flush(graphicsDriver graphicsdriver.Graphics, endFrame bo
// FlushCommands flushes the command queue and present the screen if needed. // FlushCommands flushes the command queue and present the screen if needed.
// If endFrame is true, the current screen might be used to present. // If endFrame is true, the current screen might be used to present.
func FlushCommands(graphicsDriver graphicsdriver.Graphics, endFrame bool) error { func FlushCommands(graphicsDriver graphicsdriver.Graphics, endFrame bool) error {
// Flush image buffers only when the frame ends.
// Flushing them in tests might cause test flakiness on browsers (#2391).
// TODO: Investigate why.
if endFrame {
flushImageBuffers() flushImageBuffers()
}
return theCommandQueue.Flush(graphicsDriver, endFrame) return theCommandQueue.Flush(graphicsDriver, endFrame)
} }