mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-26 03:38:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

audio/internal/readerdriver: Reduce mutext on Windows

Browse Source 
The granularity of context switches on Windows is pretty big and
mutexes might not be efficent.
This commit is contained in:
Hajime Hoshi 2021-05-28 19:25:56 +09:00
parent 646f48ef09
commit dc2f5e296e
1 changed files with 10 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
audio/internal/readerdriver/driver_windows.go
View File

@ -160,7 +160,7 @@ func (p *players) add(player *playerImpl) error {
p.headers = append(p.headers, h)
}
if err := p.readAndWriteBuffersImpl(); err != nil {
if err := p.readAndWriteBuffers(); err != nil {
return err
}
@ -205,34 +205,25 @@ func (p *players) shouldWait() bool {
return true
}
func (p *players) wait() bool {
func (p *players) loop() {
for {
p.cond.L.Lock()
defer p.cond.L.Unlock()
for p.shouldWait() {
p.cond.Wait()
}
return p.waveOut != 0
}
func (p *players) loop() {
for {
if !p.wait() {
if p.waveOut == 0 {
p.cond.L.Unlock()
return
}
if err := p.readAndWriteBuffers(); err != nil {
p.setError(err)
p.err = err
p.cond.L.Unlock()
break
}
p.cond.L.Unlock()
}
}
func (p *players) setError(err error) {
p.cond.L.Lock()
defer p.cond.L.Unlock()
p.err = err
}
func (p *players) suspend() error {
p.cond.L.Lock()
defer p.cond.L.Unlock()
@ -270,12 +261,6 @@ var waveOutOpenCallback = windows.NewCallbackCDecl(func(hwo, uMsg, dwInstance, d
})
func (p *players) readAndWriteBuffers() error {
p.cond.L.Lock()
defer p.cond.L.Unlock()
return p.readAndWriteBuffersImpl()
}
func (p *players) readAndWriteBuffersImpl() error {
if len(p.players) == 0 {
return nil
}