mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-11-13 22:47:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/graphicsdriver/opengl: reduce unnecessary slice allocations

Browse Source
This commit is contained in:
Hajime Hoshi 2022-11-17 03:01:31 +09:00
parent 9df4770d20
commit de3702e4c2
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
internal/graphicsdriver/opengl/context_js.go
View File

@ -98,15 +98,6 @@ func webGL2MightBeAvailable() bool {
return js.Global().Get("WebGL2RenderingContext").Truthy() return js.Global().Get("WebGL2RenderingContext").Truthy()
} }
func uint8ArrayToSlice(value js.Value, length int) []byte {
if l := value.Get("byteLength").Int(); length > l {
length = l
}
s := make([]byte, length)
js.CopyBytesToGo(s, value)
return s
}
type contextImpl struct { type contextImpl struct {
gl *jsGL gl *jsGL
canvas js.Value canvas js.Value
@ -237,10 +228,13 @@ func (c *context) bindFramebufferImpl(f framebufferNative) {
func (c *context) framebufferPixels(buf []byte, f *framebuffer, x, y, width, height int) { func (c *context) framebufferPixels(buf []byte, f *framebuffer, x, y, width, height int) {
c.bindFramebuffer(f.native) c.bindFramebuffer(f.native)
l := 4 * width * height if got, want := len(buf), 4*width*height; got != want {
p := jsutil.TemporaryUint8ArrayFromUint8Slice(l, nil) panic(fmt.Sprintf("opengl: len(buf) must be %d but %d", got, want))
}
p := jsutil.TemporaryUint8ArrayFromUint8Slice(len(buf), nil)
c.gl.readPixels.Invoke(x, y, width, height, gl.RGBA, gl.UNSIGNED_BYTE, p) c.gl.readPixels.Invoke(x, y, width, height, gl.RGBA, gl.UNSIGNED_BYTE, p)
copy(buf, uint8ArrayToSlice(p, l)) js.CopyBytesToGo(buf, p)
} }
func (c *context) framebufferPixelsToBuffer(f *framebuffer, buffer buffer, width, height int) { func (c *context) framebufferPixelsToBuffer(f *framebuffer, buffer buffer, width, height int) {