mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2025-02-23 16:30:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

audio/internal/readerdriver: Experimental increase of buffers

Browse Source 
Also, this change reduces goroutine uses for efficiency.

Updates #1768
This commit is contained in:
Hajime Hoshi 2021-08-18 23:19:14 +09:00
parent 045b14ba21
commit ded679c071
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
audio/internal/readerdriver/driver_windows.go
View File

@ -22,7 +22,7 @@ import (
"golang.org/x/sys/windows" "golang.org/x/sys/windows"
) )
const headerBufferSize = 4096 const headerBufferSize = 8192
func IsAvailable() bool { func IsAvailable() bool {
return true return true
@ -117,7 +117,7 @@ func NewContext(sampleRate, channelNum, bitDepthInBytes int) (Context, chan stru
} }
c.waveOut = w c.waveOut = w
c.headers = make([]*header, 0, 4) c.headers = make([]*header, 0, 3)
for len(c.headers) < cap(c.headers) { for len(c.headers) < cap(c.headers) {
h, err := newHeader(c.waveOut, headerBufferSize) h, err := newHeader(c.waveOut, headerBufferSize)
if err != nil { if err != nil {

8
audio/internal/readerdriver/player_notjs.go
View File

@ -156,6 +156,13 @@ func (p *player) Play() {
} }
func (p *playerImpl) Play() { func (p *playerImpl) Play() {
// Goroutines don't work effiently on Windows. Avoid using them (#1768).
if runtime.GOOS == "windows" {
p.m.Lock()
defer p.m.Unlock()
p.playImpl()
} else {
ch := make(chan struct{}) ch := make(chan struct{})
go func() { go func() {
p.m.Lock() p.m.Lock()
@ -166,6 +173,7 @@ func (p *playerImpl) Play() {
}() }()
<-ch <-ch
} }
}
func (p *playerImpl) playImpl() { func (p *playerImpl) playImpl() {
if p.err != nil { if p.err != nil {