mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2025-01-12 20:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

audio: Add comments about explanation how deadlock happens

Browse Source 
This might be related to #855
This commit is contained in:
Hajime Hoshi 2019-04-30 01:41:19 +09:00
parent 5ecc595ce4
commit e19479d243
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
audio/audio.go
View File

@ -370,11 +370,13 @@ func (p *playerImpl) ensureReadLoop() error {
if p.closedExplicitly {
return fmt.Errorf("audio: the player is already closed")
}
// TODO: This is not exactly atomic: there is a little chance not to run the loop even though the current
// loop is about to end. Fix this.
if p.runningReadLoop {
return nil
}
// Set runningReadLoop true here, not in the loop, or this causes deadlock with channels in Seek.
// While the for loop doesn't start, Seeks tries to send something to the channels.
// The for loop must start without any locking.
p.runningReadLoop = true
go p.readLoop()
return nil