mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2025-01-12 12:08:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

graphics: Bug fix: Don't delete buffers on browsers (#526)

Browse Source
This commit is contained in:
Hajime Hoshi 2018-03-02 01:01:27 +09:00
parent 4c1cc9e699
commit e5089934db
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
internal/graphics/program.go
View File

@ -20,6 +20,7 @@ import (
"github.com/hajimehoshi/ebiten/internal/affine" "github.com/hajimehoshi/ebiten/internal/affine"
emath "github.com/hajimehoshi/ebiten/internal/math" emath "github.com/hajimehoshi/ebiten/internal/math"
"github.com/hajimehoshi/ebiten/internal/opengl" "github.com/hajimehoshi/ebiten/internal/opengl"
"github.com/hajimehoshi/ebiten/internal/web"
) )
// arrayBufferLayoutPart is a part of an array buffer layout. // arrayBufferLayoutPart is a part of an array buffer layout.
@ -163,11 +164,16 @@ func (s *openGLState) reset() error {
if s.programScreen != zeroProgram { if s.programScreen != zeroProgram {
opengl.GetContext().DeleteProgram(s.programScreen) opengl.GetContext().DeleteProgram(s.programScreen)
} }
if s.arrayBuffer != zeroBuffer {
opengl.GetContext().DeleteBuffer(s.arrayBuffer) // On browsers (at least Chrome), buffers are already detached from the context
} // and must not be deleted by DeleteBuffer.
if s.elementArrayBuffer != zeroBuffer { if !web.IsBrowser() {
opengl.GetContext().DeleteBuffer(s.elementArrayBuffer) if s.arrayBuffer != zeroBuffer {
opengl.GetContext().DeleteBuffer(s.arrayBuffer)
}
if s.elementArrayBuffer != zeroBuffer {
opengl.GetContext().DeleteBuffer(s.elementArrayBuffer)
}
} }
shaderVertexModelviewNative, err := opengl.GetContext().NewShader(opengl.VertexShader, shader(shaderVertexModelview)) shaderVertexModelviewNative, err := opengl.GetContext().NewShader(opengl.VertexShader, shader(shaderVertexModelview))