mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-11-10 04:57:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/graphicsdriver/directx: add EBITENGINE_DIRECTX_FEATURE_LEVEL

Browse Source 
A fix for #2447 was a breaking-change as the DirectX driver was no longer
available for some old graphics card.

To support such old cards, provide a new environment variable
EBITENGINE_DIRECTX_FEATURE_LEVEL to specify a feature level.
The possible values are 11_0, 11_1, 12_0, 12_1, and 12_2. The default
value is 12_0.

Closes #2466
This commit is contained in:
Hajime Hoshi 2022-11-21 02:46:04 +09:00
parent 84dd1679e3
commit ed88559a50
3 changed files with 30 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc.go
View File

@ -81,6 +81,10 @@
// "warp": Use WARP (i.e. software rendering). // "warp": Use WARP (i.e. software rendering).
// "debug": Use a debug layer. // "debug": Use a debug layer.
// //
// `EBITENGINE_DIRECTX_FEATURE_LEVEL` environment variable specifies DirectX feature level.
// The possible values are "11_0", "11_1", "12_0", "12_1", and "12_2".
// The default value is "12_0".
//
// # Build tags // # Build tags
// //
// `ebitenginedebug` outputs a log of graphics commands. This is useful to know what happens in Ebitengine. In general, the // `ebitenginedebug` outputs a log of graphics commands. This is useful to know what happens in Ebitengine. In general, the

4
internal/graphicsdriver/directx/api_windows.go
View File

@ -75,7 +75,11 @@ const (
type _D3D_FEATURE_LEVEL int32 type _D3D_FEATURE_LEVEL int32
const ( const (
_D3D_FEATURE_LEVEL_11_0 _D3D_FEATURE_LEVEL = 0xb000
_D3D_FEATURE_LEVEL_11_1 _D3D_FEATURE_LEVEL = 0xb100
_D3D_FEATURE_LEVEL_12_0 _D3D_FEATURE_LEVEL = 0xc000 _D3D_FEATURE_LEVEL_12_0 _D3D_FEATURE_LEVEL = 0xc000
_D3D_FEATURE_LEVEL_12_1 _D3D_FEATURE_LEVEL = 0xc100
_D3D_FEATURE_LEVEL_12_2 _D3D_FEATURE_LEVEL = 0xc200
) )
type _D3D_PRIMITIVE_TOPOLOGY int32 type _D3D_PRIMITIVE_TOPOLOGY int32

28
internal/graphicsdriver/directx/graphics_windows.go
View File

@ -181,6 +181,24 @@ func (g *Graphics) initialize() (ferr error) {
} }
} }
// Ebitengine itself doesn't require the features level 12 and 11 should be enough,
// but some old cards don't work well (#2447). Specify the level 12 by default.
var featureLevel _D3D_FEATURE_LEVEL = _D3D_FEATURE_LEVEL_12_0
if env := os.Getenv("EBITENGINE_DIRECTX_FEATURE_LEVEL"); env != "" {
switch env {
case "11_0":
featureLevel = _D3D_FEATURE_LEVEL_11_0
case "11_1":
featureLevel = _D3D_FEATURE_LEVEL_11_1
case "12_0":
featureLevel = _D3D_FEATURE_LEVEL_12_0
case "12_1":
featureLevel = _D3D_FEATURE_LEVEL_12_1
case "12_2":
featureLevel = _D3D_FEATURE_LEVEL_12_2
}
}
// Initialize not only a device but also other members like a fence. // Initialize not only a device but also other members like a fence.
// Even if initializing a device succeeds, initializing a fence might fail (#2142). // Even if initializing a device succeeds, initializing a fence might fail (#2142).
@ -189,7 +207,7 @@ func (g *Graphics) initialize() (ferr error) {
return err return err
} }
} else { } else {
if err := g.initializeDesktop(useWARP, useDebugLayer); err != nil { if err := g.initializeDesktop(useWARP, useDebugLayer, featureLevel); err != nil {
return err return err
} }
} }
@ -197,7 +215,7 @@ func (g *Graphics) initialize() (ferr error) {
return nil return nil
} }
func (g *Graphics) initializeDesktop(useWARP bool, useDebugLayer bool) (ferr error) { func (g *Graphics) initializeDesktop(useWARP bool, useDebugLayer bool, featureLevel _D3D_FEATURE_LEVEL) (ferr error) {
if err := d3d12.Load(); err != nil { if err := d3d12.Load(); err != nil {
return err return err
} }
@ -264,9 +282,7 @@ func (g *Graphics) initializeDesktop(useWARP bool, useDebugLayer bool) (ferr err
continue continue
} }
// Test D3D12CreateDevice without creating an actual device. // Test D3D12CreateDevice without creating an actual device.
// Ebitengine itself doesn't require the features level 12 and 11 should be enough, if _, err := _D3D12CreateDevice(unsafe.Pointer(a), featureLevel, &_IID_ID3D12Device, false); err != nil {
// but some old cards don't work well (#2447). Specify the level 12 here.
if _, err := _D3D12CreateDevice(unsafe.Pointer(a), _D3D_FEATURE_LEVEL_12_0, &_IID_ID3D12Device, false); err != nil {
continue continue
} }
@ -279,7 +295,7 @@ func (g *Graphics) initializeDesktop(useWARP bool, useDebugLayer bool) (ferr err
return errors.New("directx: DirectX 12 is not supported") return errors.New("directx: DirectX 12 is not supported")
} }
d, err := _D3D12CreateDevice(unsafe.Pointer(adapter), _D3D_FEATURE_LEVEL_12_0, &_IID_ID3D12Device, true) d, err := _D3D12CreateDevice(unsafe.Pointer(adapter), featureLevel, &_IID_ID3D12Device, true)
if err != nil { if err != nil {
return err return err
} }