mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-26 11:48:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/graphicsdriver/directx: batch ExecuteCommandList

Browse Source 
Updates #2188
This commit is contained in:
Hajime Hoshi 2022-07-15 00:33:48 +09:00
parent 82d31c5fb7
commit f92107c2ee
1 changed files with 45 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
internal/graphicsdriver/directx/graphics_windows.go
View File

@ -632,15 +632,12 @@ func (g *Graphics) initSwapChainXbox(width, height int) (ferr error) {
} }
func (g *Graphics) resizeSwapChainDesktop(width, height int) error { func (g *Graphics) resizeSwapChainDesktop(width, height int) error {
if err := g.flushCommandList(g.copyCommandList); err != nil { if err := g.flushCommandList(g.copyCommandList, g.drawCommandList); err != nil {
return err return err
} }
if err := g.copyCommandList.Close(); err != nil { if err := g.copyCommandList.Close(); err != nil {
return err return err
} }
if err := g.flushCommandList(g.drawCommandList); err != nil {
return err
}
if err := g.drawCommandList.Close(); err != nil { if err := g.drawCommandList.Close(); err != nil {
return err return err
} }
@ -749,22 +746,18 @@ func (g *Graphics) Begin() error {
func (g *Graphics) End(present bool) error { func (g *Graphics) End(present bool) error {
// The swap chain might still be nil when Begin-End is invoked not by a frame (e.g., Image.At). // The swap chain might still be nil when Begin-End is invoked not by a frame (e.g., Image.At).
// As copyCommandList and drawCommandList are exclusive, the order should not matter here. if present {
if err := g.flushCommandList(g.copyCommandList); err != nil { g.screenImage.transiteState(g.drawCommandList, _D3D12_RESOURCE_STATE_PRESENT)
}
if err := g.flushCommandList(g.copyCommandList, g.drawCommandList); err != nil {
return err return err
} }
if err := g.copyCommandList.Close(); err != nil { if err := g.copyCommandList.Close(); err != nil {
return err return err
} }
if present {
g.screenImage.transiteState(g.drawCommandList, _D3D12_RESOURCE_STATE_PRESENT)
}
if err := g.drawCommandList.Close(); err != nil { if err := g.drawCommandList.Close(); err != nil {
return err return err
} }
g.commandQueue.ExecuteCommandLists([]*_ID3D12GraphicsCommandList{g.drawCommandList})
// Release vertices and indices buffers when too many ones were created. // Release vertices and indices buffers when too many ones were created.
// This is needed espciallly for testings, where present is always false. // This is needed espciallly for testings, where present is always false.
@ -885,30 +878,41 @@ func (g *Graphics) releaseVerticesAndIndices(frameIndex int) {
// flushCommandList executes commands in the command list and waits for its completion. // flushCommandList executes commands in the command list and waits for its completion.
// //
// TODO: This is not efficient. Is it possible to make two command lists work in parallel? // TODO: This is not efficient. Is it possible to make two command lists work in parallel?
func (g *Graphics) flushCommandList(commandList *_ID3D12GraphicsCommandList) error { func (g *Graphics) flushCommandList(commandLists ...*_ID3D12GraphicsCommandList) error {
var flushingCommandLists []*_ID3D12GraphicsCommandList
for _, commandList := range commandLists {
switch commandList { switch commandList {
case g.drawCommandList: case g.drawCommandList:
if !g.needFlushDrawCommandList { if !g.needFlushDrawCommandList {
return nil continue
} }
g.needFlushDrawCommandList = false g.needFlushDrawCommandList = false
flushingCommandLists = append(flushingCommandLists, commandList)
case g.copyCommandList: case g.copyCommandList:
if !g.needFlushCopyCommandList { if !g.needFlushCopyCommandList {
return nil continue
} }
g.needFlushCopyCommandList = false g.needFlushCopyCommandList = false
flushingCommandLists = append(flushingCommandLists, commandList)
}
} }
if len(flushingCommandLists) == 0 {
return nil
}
for _, commandList := range flushingCommandLists {
if err := commandList.Close(); err != nil { if err := commandList.Close(); err != nil {
return err return err
} }
}
g.commandQueue.ExecuteCommandLists([]*_ID3D12GraphicsCommandList{commandList}) g.commandQueue.ExecuteCommandLists(flushingCommandLists)
if err := g.waitForCommandQueue(); err != nil { if err := g.waitForCommandQueue(); err != nil {
return err return err
} }
for _, commandList := range flushingCommandLists {
switch commandList { switch commandList {
case g.drawCommandList: case g.drawCommandList:
if err := g.drawCommandAllocators[g.frameIndex].Reset(); err != nil { if err := g.drawCommandAllocators[g.frameIndex].Reset(); err != nil {
@ -925,6 +929,7 @@ func (g *Graphics) flushCommandList(commandList *_ID3D12GraphicsCommandList) err
return err return err
} }
} }
}
return nil return nil
} }