mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-11-10 04:57:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

internal/atlas: Bug fix: Set the minimum texture size to 8192px

Browse Source 
Closes #1675
Updates #1674
This commit is contained in:
Hajime Hoshi 2021-06-19 18:52:05 +09:00
parent 43c964a3b8
commit fa8e271f2a
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
internal/atlas/image.go
View File

@ -45,6 +45,13 @@ func max(a, b int) int {
return b
}
func min(a, b int) int {
if a < b {
return a
}
return b
}
func init() {
hooks.AppendHookOnBeforeUpdate(func() error {
backendsM.Lock()
@ -70,17 +77,10 @@ func resolveDeferred() {
// Actual time duration is increased in an exponential way for each usages as a rendering target.
const baseCountToPutOnAtlas = 10
func min(a, b uint) uint {
if a < b {
return a
}
return b
}
func putImagesOnAtlas() error {
for i := range imagesToPutOnAtlas {
i.usedAsSourceCount++
if i.usedAsSourceCount >= baseCountToPutOnAtlas*(1<<min(uint(i.isolatedCount), 31)) {
if i.usedAsSourceCount >= baseCountToPutOnAtlas*(1<<uint(min(i.isolatedCount, 31))) {
if err := i.putOnAtlas(); err != nil {
return err
}
@ -715,8 +715,11 @@ func BeginFrame() error {
if len(theBackends) != 0 {
panic("atlas: all the images must be not on an atlas before the game starts")
}
minSize = 1024
maxSize = max(minSize, restorable.MaxImageSize())
// Use 8192 as a minimum texture size to reduce chences to extend the texture (#1675).
// For example, extending a texture size from 4096px to 8192px might be slow in some environments.
// TODO: Extending a texture to 16384px can be very slow (#1674).
minSize = min(8192, restorable.MaxImageSize())
maxSize = restorable.MaxImageSize()
})
if err != nil {
return err