mth/ebiten
1
0
Fork 0
mirror of https://github.com/hajimehoshi/ebiten.git synced 2024-12-24 02:38:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

graphicsdriver/metal: Bug fix: Sync textures before replacing a region

Browse Source 
Updates #1213
This commit is contained in:
Hajime Hoshi 2020-06-27 03:03:53 +09:00
parent 7b6182d05a
commit 2bc1475a15
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/graphicsdriver/metal/graphics.go
View File

@ -440,7 +440,7 @@ func (g *Graphics) NewImage(width, height int) (driver.Image, error) {
Width: graphics.InternalImageSize(width),
Height: graphics.InternalImageSize(height),
StorageMode: storageMode,
Usage: textureUsage,
Usage: mtl.TextureUsageShaderRead | mtl.TextureUsageRenderTarget,
}
var t mtl.Texture
g.t.Call(func() error {
@ -873,6 +873,10 @@ func (i *Image) ReplacePixels(args []*driver.ReplacePixelsArgs) {
if g.drawCalled {
g.flush(true, false)
g.drawCalled = false
// When mtl.TextureUsageRenderTarget is specified, synchronizing the texture memory before replacing
// a region seems necessary (#1213).
i.syncTexture()
}
g.t.Call(func() error {

2
internal/graphicsdriver/metal/view_ios.go
View File

@ -58,8 +58,6 @@ func (v *view) update() {
}
const (
textureUsage = mtl.TextureUsageShaderRead | mtl.TextureUsageRenderTarget
storageMode = mtl.StorageModeShared
resourceStorageMode = mtl.ResourceStorageModeShared
)

3
internal/graphicsdriver/metal/view_macos.go
View File

@ -46,9 +46,6 @@ func (v *view) update() {
}
const (
// MTLTextureUsageRenderTarget might cause a problematic render result. Not sure the reason.
textureUsage = mtl.TextureUsageShaderRead
storageMode = mtl.StorageModeManaged
resourceStorageMode = mtl.ResourceStorageModeManaged
)