Hajime Hoshi
4c70ad382d
audio/mp3: Bug fix: Avoid using a detached ArrayBuffer
2018-06-24 02:12:00 +09:00
Hajime Hoshi
5aefa837db
audio/mp3: Use gopherwasm
2018-06-24 01:42:16 +09:00
Hajime Hoshi
273093b237
audio: Skip the player in the state of starting, seeking or EOF
...
This is basically reland of
2fee7a6fe5
.
Before this change, if a player's buffer was not enough for
reading, 0 value were used and this caused noises. The reading
size should be aligned with all the players.
However, there are some cases that the player should be skippped.
For example, just after a player just starts playing or seeking,
the buffer is empty. In this case, other players should not wait
for the player since decoding might take some time. Another case
is that the player reached EOF.
This change aligns the read buffer sizes but use zero values only
when the player just starts or seeks, or reaches EOF.
2018-06-09 22:00:11 +09:00
Hajime Hoshi
facf184548
Revert "audio: Consider the state of the player's starting and seeking"
...
This reverts commit 2fee7a6fe5
.
Reason: This causes freezing on browsers
2018-06-09 19:28:20 +09:00
Hajime Hoshi
b62e07b9bd
audio: Remove println
2018-06-09 19:05:07 +09:00
Hajime Hoshi
2fee7a6fe5
audio: Consider the state of the player's starting and seeking
...
Before this change, if a player's buffer was not enough for
reading, 0 value were used and this caused noises. The reading
size should be aligned with all the players.
Just after a player just starts playing or seeking, the buffer is
empty but other players should not wait for the player read since
decoding might take some time.
To summerize, this change aligns the read buffer sizes but use
zero values only when the player just starts or seeks.
2018-06-09 19:01:57 +09:00
Hajime Hoshi
91958d24ef
audio: Use bigger buffers for mobiles
2018-06-09 18:14:18 +09:00
Hajime Hoshi
faaf391619
audio: Give up syncing audio timer and game timer ( #617 )
...
Syncing was already incomplete (e.g. decoding takes more than one
frame and delays can happen in this case). Giving up syncing audio
timer and game timer should not affect the game experience so much.
Instead, clock implementation will be much simpler.
2018-05-27 00:30:12 +09:00
Hajime Hoshi
5976e4bbbc
audio: More intellegent suspending/resuming ( #617 )
...
Before this change, the audio is suspended when the game stops for
1/12[s]. However, as game often stops for more than 1/12[s]
especially on mobiles, this implemntation caused some audio
glitches.
This change fixes this problem by re-implementing suspending/
resumeing audio by detecting the window is active/focused or not.
2018-05-26 23:31:04 +09:00
Hajime Hoshi
df048d9bf6
audio: Don't use nosync GopherJS
...
nosync package is good in terms of performance, but this assumes
that duplicated lock never happens. As audio package runs multiple
goroutines, theoretically duplicated lock can happen, and it looks
like this is an actual case (#603 ).
This change replaces nosync usages with regular sync usages.
Probably I'll deprecate nosync usages via internal/sync package
everywhere in Ebiten.
This might fix #603 .
2018-05-09 12:14:20 +09:00
Hajime Hoshi
83f168a010
audio/vorbis: Bug fix: fail to decode too short ogg
2018-04-07 22:13:12 +09:00
Hajime Hoshi
75ac8e6f2b
vorbis: Add tests ( #570 )
2018-03-31 01:51:39 +09:00
Hajime Hoshi
a31874ed48
vorbis: Bug fix: Length returned wrong result with monoral source ( #570 )
2018-03-30 11:59:03 +09:00
Hajime Hoshi
f1f0277deb
wav: Set finalizer for the stream
2018-03-27 12:10:57 +09:00
Hajime Hoshi
88cfd219e7
mp3: Set finalizer for the stream
2018-03-27 10:58:13 +09:00
Hajime Hoshi
f4e018a336
vorbis: Bug fix: Read was not responsible with Close ( #569 )
2018-03-27 10:51:21 +09:00
Hajime Hoshi
632a97974d
audio: Fix wrong English word
2018-03-22 00:36:48 +09:00
Hajime Hoshi
18113f259a
audio: NewPlayer now accepts io.ReadCloser
...
Fixes #414
2018-03-22 00:33:17 +09:00
Hajime Hoshi
1b0e71765f
internal/hooks: Rename Update -> BeforeUpdate
2018-03-15 02:50:10 +09:00
Hajime Hoshi
063153e41d
ebitenutil: Speed up to avoid copying by image.Rect
2018-03-11 21:39:22 +09:00
Hajime Hoshi
61950817fa
audio: Bug fix: importing audio without NewContext causes error
2018-03-04 22:18:14 +09:00
Hajime Hoshi
647d8f0094
audio: Use time.NewTimer and Stop instead of time.After
...
Fixes #532
2018-03-04 19:23:38 +09:00
Hajime Hoshi
392ee92aeb
Add internal/hooks to replace internal/audiobinding
2018-02-04 17:33:17 +09:00
Hajime Hoshi
2322c5600b
audio: Revert the buffer size
...
This basically reverts df62b16270
.
2018-01-29 11:57:52 +09:00
Hajime Hoshi
5c55df87d7
audio: Deprecate Size() and add Length() ( #466 )
2018-01-09 01:25:38 +09:00
Hajime Hoshi
ef282f7f4f
audio/internal/convert: Remove unused functions
2018-01-09 00:26:54 +09:00
Hajime Hoshi
e83810fc57
audio/internal/convert: Add resampling_test.go
...
Fixes #369
2018-01-08 23:44:44 +09:00
Hajime Hoshi
d5d5ebb0b3
clock: Make ProceedAudioTimer take a number of frames
2018-01-07 18:32:19 +09:00
Hajime Hoshi
d12a3d4073
clock: Refactoring
2018-01-07 17:10:56 +09:00
Hajime Hoshi
0b3495b81f
audio: Use mock sync on browsers
2018-01-07 15:26:18 +09:00
Hajime Hoshi
11a1e6ec39
audio/internal/convert: Adjust window size again (confirmed this worked well on iPhone 6)
2018-01-06 01:49:55 +09:00
Hajime Hoshi
5b2dbf6036
audio/internal/convert: Adjust resamplingBufferSize again
2018-01-06 01:46:54 +09:00
Hajime Hoshi
ab70f6fc58
audio/internal/convert: Much faster sine/cosine functions
2018-01-06 00:15:07 +09:00
Hajime Hoshi
005d18ceff
audio/internal/convert: Use int64 (now it is fast enough on browsers?)
2018-01-05 20:03:17 +09:00
Hajime Hoshi
c020101afc
audio/internal/convert: Use cosine table
2018-01-05 19:40:12 +09:00
Hajime Hoshi
2884fb7070
audio/internal/convert: Fix algorithm
2018-01-05 18:21:14 +09:00
Hajime Hoshi
df62b16270
audio: Use bigger buffer size for mobile phones
2017-12-31 01:28:08 +09:00
Hajime Hoshi
de1a22d9f3
audio/internal/convert: Bug fix: remove unneeded import
2017-12-31 00:15:36 +09:00
Hajime Hoshi
03942292f5
audio/internal/convert: Change the window smaller for performance
...
On iOS, resapling performance was not good.
2017-12-31 00:14:52 +09:00
Hajime Hoshi
97ec367e23
audio: Use :=
2017-12-30 21:18:34 +09:00
Hajime Hoshi
65c0bf55fc
audio: Fix buffer size for the latest Oto
2017-12-28 20:37:36 +09:00
Hajime Hoshi
a98b03f738
audio/mp3: Flexible timeout
2017-12-27 19:18:02 +09:00
Hajime Hoshi
e2a026138a
audio/internal/convert: Use float64 for positions
2017-12-27 18:55:17 +09:00
Hajime Hoshi
6d6504085c
audio/internal/convert: Rename members
2017-12-27 18:05:55 +09:00
Hajime Hoshi
50a6158513
audio/mp3: Adjust timeout
2017-12-26 14:55:01 +09:00
Hajime Hoshi
3855bcc5a4
audio/mp3: Change the timeout for decoding (for Firefox)
2017-12-26 00:59:36 +09:00
Hajime Hoshi
ad54538d07
audio/mp3: Use byte instead of uint8
2017-12-26 00:11:17 +09:00
Hajime Hoshi
bb44eebe78
audio/mp3: Replace magic numbers with consts in io package
2017-12-26 00:10:30 +09:00
Hajime Hoshi
908ccb9404
audio/mp3: Try again decoding when timed out ( #464 )
2017-12-26 00:08:33 +09:00
Hajime Hoshi
623caad3ec
audio: Bug fix: appropriate buffer size on browsers
2017-12-25 01:54:55 +09:00
Hajime Hoshi
60eef4618d
audio: Revert size (due to noise on browsers)
2017-12-25 00:16:47 +09:00
Hajime Hoshi
4a06198160
audio: Smaller buffers (experimental)
2017-12-24 22:16:45 +09:00
Hajime Hoshi
5679103d71
audio: Use io.CopyN
2017-12-24 21:21:15 +09:00
Hajime Hoshi
a74cf21f21
audio/mp3: Revert calling Gosched(): Looks like this doesn't make sense
2017-12-24 04:53:51 +09:00
Hajime Hoshi
2155b2f04a
audio/mp3: Channels should be used only once
2017-12-24 04:40:20 +09:00
Hajime Hoshi
e14257d76d
audio: A little better buffer size for Android Chrome
2017-12-24 04:01:41 +09:00
Hajime Hoshi
ae6bdf23f2
audio: Recalculate audio buffer size
2017-12-24 03:54:42 +09:00
Hajime Hoshi
7b1f501bd7
audio/mp3: Force context switch when decoding
2017-12-24 03:14:10 +09:00
Hajime Hoshi
18c6890d96
audio: More often reading (decoding) audio source to reduce noise
2017-12-24 00:58:14 +09:00
Hajime Hoshi
7ce87a6c82
audio: Simplify read/write logic
2017-12-24 00:51:17 +09:00
Hajime Hoshi
00d8d61795
audio: Adjust buffer size
2017-12-23 23:15:44 +09:00
Hajime Hoshi
f3997cf5ae
audio: Fix comments
2017-12-23 21:14:08 +09:00
Hajime Hoshi
a540d6b2bb
audio: Adjust buffer size
2017-12-23 19:59:52 +09:00
Hajime Hoshi
19ca74e86b
audio: Remove player's mutex
2017-12-23 19:01:28 +09:00
Hajime Hoshi
637ed0d965
audio: Refactoring
2017-12-23 18:39:14 +09:00
Hajime Hoshi
04739a7249
audio: Bug fix: Seek might cause dead lock after Close
2017-12-23 18:31:20 +09:00
Hajime Hoshi
db77658935
audio: Reduce locks by using channels
2017-12-23 17:55:48 +09:00
Hajime Hoshi
ba3de063ac
audio: Refactoring
2017-12-23 17:05:14 +09:00
Hajime Hoshi
3dcb486a5c
audio: Refactoring
2017-12-23 05:02:15 +09:00
Hajime Hoshi
7cc6154de6
audio: Reduce noise ( #443 )
2017-12-23 04:25:48 +09:00
Hajime Hoshi
3addbfce8a
audio: Simplify error handling
2017-12-23 04:12:12 +09:00
Hajime Hoshi
a21571fb57
audio: Refactoring
2017-12-23 04:01:18 +09:00
Hajime Hoshi
a5f8c1b1f8
audio: Async reading sources ( #443 )
2017-12-23 03:24:54 +09:00
Hajime Hoshi
31350dc497
mp3: Avoid calling Length() if possible ( #463 )
2017-12-22 05:17:01 +09:00
Hajime Hoshi
7b76b7822f
audio: Fix comments
2017-12-17 01:24:45 +09:00
Hajime Hoshi
7cd89bc44b
audio: Adjust buffer size for Android Chrome
2017-12-17 01:20:10 +09:00
Hajime Hoshi
7f9afd4e14
audio: Unify buffer size 1/15[s] experimentally
...
This would mitigate glitches on Windows (#451 )
2017-12-17 00:41:35 +09:00
Hajime Hoshi
6956e15b08
audio: Fix comments
2017-12-02 16:26:20 +09:00
Hajime Hoshi
3db965d547
audio: Fix doc
2017-12-01 01:38:47 +09:00
Hajime Hoshi
0379e3c591
audio: Deprecate Update
2017-12-01 00:26:28 +09:00
Hajime Hoshi
dba7124e38
audio: Use safer buffer size as experiment ( #451 )
2017-11-23 23:31:26 +09:00
Hajime Hoshi
b46ed224a7
mp3: Add comment about error handling
2017-10-18 02:11:09 +09:00
Hajime Hoshi
2624ed6824
audio: Refactoring
2017-10-14 19:45:32 +09:00
Hajime Hoshi
bc2469a275
audio: Fix wrong comments
2017-10-01 18:07:18 +09:00
Hajime Hoshi
626b772b25
doc: Improve comments
2017-10-01 17:24:30 +09:00
Hajime Hoshi
b4e3e9375c
audio: Use samller window for resampling on browsers
2017-09-29 02:05:14 +09:00
Hajime Hoshi
2c6f6e605e
audio/mp3: Bug fix: Decode error on Safari ( #438 )
2017-09-28 03:10:51 +09:00
Hajime Hoshi
1f051b50db
audio/mp3: Handle error when decoding
2017-09-28 00:55:18 +09:00
Hajime Hoshi
fe2380f1ab
audio: Add comments
2017-09-26 00:38:50 +09:00
Hajime Hoshi
d9f6699b7f
audio: Bug fix: Super noisy with 32000 Hz on browsers
2017-09-25 08:04:28 +09:00
Hajime Hoshi
8e75964cb1
audio: Adjust buffer size for browsers ( #434 )
2017-09-24 20:16:07 +09:00
Hajime Hoshi
32b33dd86d
audio/mp3: Fix comments
2017-09-24 19:28:09 +09:00
Hajime Hoshi
8725589619
audio/mp3: Bug fix: decoding a mono MP3 panics on browsers ( #421 )
2017-08-28 01:36:27 +09:00
Hajime Hoshi
a225f666ac
audio: Bug fix: Race condition on 'pos' member ( #413 )
2017-08-17 11:48:29 +09:00
Hajime Hoshi
8c3a020693
audio: Bug fix: Race condition when seeking ( #413 )
2017-08-17 11:44:30 +09:00
Hajime Hoshi
3216d50460
audio: Refactoring
2017-08-17 11:15:04 +09:00
Hajime Hoshi
ba75592807
audio: Bug fix: Race condition ( #412 )
2017-08-17 11:05:59 +09:00
Hajime Hoshi
95a061df7f
loop: Remove dependency from audio to loop
2017-08-06 01:43:09 +09:00
Hajime Hoshi
2e7a477f9d
clock: Refactoring
2017-08-06 01:28:14 +09:00
Hajime Hoshi
b7d559fdf3
clock: Refactoring: Move frames calculation to clock
2017-08-06 00:18:38 +09:00