Hajime Hoshi
0de024229d
audio: Guarantee that (*Player).Current's returning value is increased monotonically
...
Closes #1501
2021-03-31 23:41:28 +09:00
Hajime Hoshi
83dc3966e7
audio/internal/go2cpp: Bug fix: Set the volume whenever the player state is
2021-03-31 21:08:32 +09:00
Hajime Hoshi
f0d7e16eb2
audio/internal/readerdriver: Refactoring
2021-03-28 23:27:47 +09:00
Hajime Hoshi
bf4c1e3d74
audio: Bug fix: Compile error for tests
2021-03-28 22:57:50 +09:00
Hajime Hoshi
f4efdd6355
audio/internal/go2cpp: Protect the functions by the lock correctly
2021-03-28 22:40:36 +09:00
Hajime Hoshi
f4b770eff6
audio/internal/readerdriver: Add Player.Err
2021-03-28 22:21:07 +09:00
Hajime Hoshi
b46cb324ed
audio: Add audio/internal/readerdriver package
2021-03-28 18:34:16 +09:00
Hajime Hoshi
7212cd7999
audio: Bug fix: Race condition on accessing the set of players
...
Closes #1548
2021-03-24 23:41:18 +09:00
Hajime Hoshi
7696d51839
audio: Bug fix: Duplicated pausing at reader players
...
This caused unexpected 'Unread' calls.
2021-03-24 00:19:49 +09:00
Hajime Hoshi
1083233d5f
audio/internal/go2cpp: Replace isWritable with unplayedBufferSize instead
...
This is the more accurate way not to overflow the underlying buffer.
2021-03-23 23:46:57 +09:00
Hajime Hoshi
6f185063d6
audio: Ensure Close is called at a readerPlayer is GCed
2021-03-22 04:11:08 +09:00
Hajime Hoshi
07c10880f4
audio: Bug fix: Test failures on browsers
2021-03-22 03:50:05 +09:00
Hajime Hoshi
a17fea39a1
audio: Bug fix: Compile error on Go 1.13
2021-03-22 02:16:46 +09:00
Hajime Hoshi
49a8a491cd
audio: Implement the reader player for browsers
...
Updates #1458
2021-03-22 01:53:52 +09:00
Hajime Hoshi
9e73b0d287
audio: Rename UnwrittenBufferSize -> UnplayedBufferSize
2021-03-01 01:27:42 +09:00
Hajime Hoshi
6d442c0a17
audio: Add comments
2021-02-28 23:47:57 +09:00
Hajime Hoshi
4bc0bb607b
audio: Lazy initialization at reader players
2021-02-28 23:41:30 +09:00
Hajime Hoshi
dbdfce5fed
audio: Add readerDriverPlayer.UnwrittenBufferSize to get the exact position
2021-02-28 01:42:48 +09:00
Hajime Hoshi
b8cdcdb847
audio: Bug fix: NewInfiniteLoop(WithIntro) should work with incomplete values
...
Closes #1503
2021-02-22 02:15:45 +09:00
Hajime Hoshi
29099cf660
audio: Bug fix: Continue to play the audio after seeking on go2cpp
2021-02-21 23:54:43 +09:00
Hajime Hoshi
027463ff88
audio: Bug fix: timeStream was not used for a reader player
2021-02-21 18:48:58 +09:00
Hajime Hoshi
68411e9591
audio/internal/go2cpp: Avoid unnecessary allocations
2021-01-25 03:09:13 +09:00
Hajime Hoshi
c8ba51d26e
audio/internal/convert: Avoid unnecessary allocations
2021-01-25 03:04:53 +09:00
Hajime Hoshi
514904392c
audio: Bug fix: Deadlock at acquiring the semaphore
...
Closes #1469
2021-01-23 23:07:19 +09:00
Hajime Hoshi
fbc7b3c884
audio/vorbis: Bug fix: Resampling didn't work correctly
2021-01-19 00:41:47 +09:00
Hajime Hoshi
2432530b51
Revert "audio/internal/go2cpp: Fix C++ side and remove the preparation"
...
This reverts commit 65f974588c
.
Reason: Didn't improve the performance on some devices
2021-01-17 04:48:11 +09:00
Hajime Hoshi
65f974588c
audio/internal/go2cpp: Fix C++ side and remove the preparation
2021-01-17 03:47:45 +09:00
Hajime Hoshi
ed7d7e8976
audio/internal/go2cpp: Prepare the first buffer data to make the audio smoother
2021-01-16 03:28:47 +09:00
Hajime Hoshi
c742ae60bd
audio: Bug fix: Implement renaderPlayer.IsPlayer correctly
2021-01-16 01:02:07 +09:00
Hajime Hoshi
ad218eae2d
audio/internal/convert: Reduce allocations of float32 slices
2021-01-15 00:37:21 +09:00
Hajime Hoshi
612676cb19
audio/internal/go2cpp: Remove the buffer size argument
2021-01-13 22:30:52 +09:00
Hajime Hoshi
aeaa443bf2
audio/internal/go2cpp: Bug fix: Writing data must be concurrent-safe
2021-01-13 10:26:30 +09:00
Hajime Hoshi
78789a511c
Revert "audio: Seek the source first at readerPlayer"
...
This reverts commit 68f12f066e
.
Reason: Some data can be read after seeking before resetting
2021-01-13 02:01:00 +09:00
Hajime Hoshi
68f12f066e
audio: Seek the source first at readerPlayer
2021-01-12 22:52:26 +09:00
Hajime Hoshi
2f8172f819
audio/internal/go2cpp: Recreate the underlying audio player when resetting
2021-01-12 20:42:45 +09:00
Hajime Hoshi
a66097df19
audio/internal/go2cpp: Remove unnecessary set
2021-01-12 11:38:30 +09:00
Hajime Hoshi
2dc37d30de
audio/internal/go2cpp: Add a comment
2021-01-12 01:07:36 +09:00
Hajime Hoshi
a7dd00596a
audio/internal/go2cpp: Add signaling at Pause
2021-01-12 00:43:16 +09:00
Hajime Hoshi
c009070840
audio/internal/go2cpp: Add readerDriverPlayer.Reset
2021-01-11 23:54:43 +09:00
Hajime Hoshi
3abb7a3604
audio/internal/go2cpp: Increase the temporary buffer size
2021-01-11 21:56:47 +09:00
Hajime Hoshi
8e6c3a570e
audio/internal/go2cpp: Bug fix: Pass the correct size
2021-01-11 18:07:25 +09:00
Hajime Hoshi
9cc5bd80f9
audio/internal/go2cpp: Better waiting condition
2021-01-11 15:37:40 +09:00
Hajime Hoshi
dc8217dfeb
audio/internal/go2cpp: Bug fix: Wrong state
2021-01-11 15:25:53 +09:00
Hajime Hoshi
52942751f0
audio: Move go2cpp -> internal/go2cpp
2021-01-09 18:21:32 +09:00
Hajime Hoshi
3579e1d0b7
audio: Implement timeStream
2021-01-09 17:16:37 +09:00
Hajime Hoshi
a2a7f5e701
audio: Add an implementation for go2cpp
2021-01-09 17:16:34 +09:00
Hajime Hoshi
bd3e930eef
audio: Add readerPlayerFactory / readerDriver
2021-01-09 00:45:13 +09:00
Hajime Hoshi
bd1c3ff030
audio: Rename writerContext -> writerPlayerFactory
2021-01-07 11:24:40 +09:00
Hajime Hoshi
a6b3f32f3a
audio: Refactoring
2021-01-07 02:14:42 +09:00
Hajime Hoshi
e04e709a10
audio: Refactor test files
2021-01-07 01:53:41 +09:00
Hajime Hoshi
bda285b376
audio: Refactoring
2021-01-07 01:33:57 +09:00
Hajime Hoshi
e77beac235
audio: Define playerImpl interface
2021-01-07 00:59:13 +09:00
Hajime Hoshi
7cf32efcd5
audio: Rename playerImpl -> writerContextPlayerImpl
2021-01-07 00:46:50 +09:00
Hajime Hoshi
c42a40a541
audio: Rename context -> writerContext
...
This is a preparation of a new type of context with io.Readers.
2021-01-07 00:26:28 +09:00
Hajime Hoshi
9849cb5c2b
audio/wav: Add DecodeWithSampleRate
...
Closes #1460
2021-01-06 23:09:52 +09:00
Hajime Hoshi
b78dde0e37
audio/mp3: Add DecodeWithSampleRate
...
Updates #1460
2021-01-06 23:03:50 +09:00
Hajime Hoshi
f6a440765b
audio/vorbis: Fix comments
2021-01-06 23:02:56 +09:00
Hajime Hoshi
96ca0a7ff9
audio/vorbis: Add DecodeWithSampleRate
...
Updates #1460
2021-01-06 22:57:25 +09:00
Hajime Hoshi
30278b80aa
audio: Use the larget buffer size for go2cpp
2021-01-05 16:07:36 +09:00
Hajime Hoshi
0bf6eee605
audio: Reduce making a slice at a player's read
2021-01-04 21:51:26 +09:00
Hajime Hoshi
3fb304e5a8
audio/internal/convert: Refactoring
2021-01-04 21:42:00 +09:00
Hajime Hoshi
f292594184
audio: Use a new implentation for go2cpp in Oto
2020-12-30 19:21:15 +09:00
Hajime Hoshi
9a705c64f3
audio: Bug fix: Compile error
2020-12-21 18:39:06 +09:00
Hajime Hoshi
2a2866bf65
audio: Use a null context on go2cpp
2020-12-21 18:35:42 +09:00
Hajime Hoshi
8e46769284
audio: Remove returning values from Play/Pause
2020-10-10 23:45:18 +09:00
Hajime Hoshi
0673b384d8
audio: Update the comment
...
Updates #859
2020-10-07 23:43:38 +09:00
Hajime Hoshi
f1f7b350de
audio, audio/mp3, audio/vorbis, audio/wav: Remove Close functions
...
Fixes #859
2020-10-07 23:39:58 +09:00
Hajime Hoshi
426cb5948a
audio/vorbis: Remove the GopherJS part
...
Updates #1129
2020-10-07 01:33:19 +09:00
Hajime Hoshi
a22fdee171
audio/mp3: Remove the GopherJS part
...
Updates #1129
2020-10-07 01:33:19 +09:00
Hajime Hoshi
944a19c6f7
audio: Remove the error returning value from NewContext
...
Updates #1380
2020-10-05 02:25:13 +09:00
Hajime Hoshi
29b4087ebf
audio: Remove the error returning value from NewPlayerFromBytes
...
Updates #1380
2020-10-05 02:18:27 +09:00
Hajime Hoshi
f4d050161a
audio: Remove (*Context).Update
...
Updates #1127
2020-10-04 15:41:34 +09:00
Hajime Hoshi
825972b3e1
audio/mp3, audio/vorbis, audio/wav: Remove deprecated functions
...
Updates #1127
2020-10-04 15:35:17 +09:00
Hajime Hoshi
bf515bb594
Update version to v2.0.0-alpha
2020-10-04 04:30:40 +09:00
Hajime Hoshi
9906e4b882
go generate
2020-09-20 23:28:17 +09:00
Hajime Hoshi
01a84a7121
audio/mp3: Make panic messages more consistent
2020-08-23 19:50:43 +09:00
Hajime Hoshi
d0181ce130
audio/wav: Remove an unused function
2020-08-23 19:49:31 +09:00
Hajime Hoshi
50fc914d72
Revert "audio/wav: Allow passing non-io.Seeker to Decode"
...
This reverts commit 19cd69da55
.
Reason: Marked #1202 'won't fix'
2020-08-23 19:46:28 +09:00
Hajime Hoshi
19cd69da55
audio/wav: Allow passing non-io.Seeker to Decode
...
Updates #1202
2020-08-23 19:15:20 +09:00
Hajime Hoshi
a1ac574a60
docs: Use 'Deprecated:' annotation
...
Fixes #1160
2020-05-19 01:50:55 +09:00
Hajime Hoshi
4fa52dcc56
Remove MonoGame support
...
Fixes #1148
2020-05-08 19:32:28 +09:00
Hajime Hoshi
2e49ed5402
audio: Add a mock implementation for MonoGame
...
Updates #1078
2020-04-21 23:59:41 +09:00
Hajime Hoshi
7ac6b0bfa3
Update dependencies
2020-03-31 03:32:38 +09:00
hiroebe
ad00414a2a
audio: Remove duplicate check for io.Seeker ( #1051 )
2020-01-10 19:37:31 +09:00
Hajime Hoshi
5182060899
Revert "audio: Bug fix: Fill empty data even when audio is suspended"
...
This reverts commit 529dddda53
.
Updates #975
Reason: This causes PARTIAL_WAKE_LOCK on Android (AudioDirectOut) (#931 )
2019-11-09 15:24:56 +09:00
Hajime Hoshi
529dddda53
audio: Bug fix: Fill empty data even when audio is suspended
...
When writing is stopped on Oto's players, unexpected delaying
happens.
The ideal solution is to have APIs to suspend and resume Oto's
player, but this is not easy. For a temporary solution, write
zero values on the players when audio is suspended.
Fixes #975
2019-11-07 01:13:00 +09:00
Hajime Hoshi
3c29fbdce2
jsutil: Refactoring: SliceToTypedArray -> CopySliceToJS
...
This unifieslocations of the temporary buffer.
2019-10-30 00:35:48 +09:00
Hajime Hoshi
fe805d7fd1
audio/vorbis/internal/stb: Bug fix: Forbid to use it from Wasm
2019-10-28 00:07:38 +09:00
Hajime Hoshi
f50875ff4b
Change the build tag strategy: GopehrJS or not GopherJS
2019-10-27 23:33:22 +09:00
Hajime Hoshi
124389561c
audio: Bug fix: The dummy player should have long enough buffer
...
In the current implementation, the audio context will be ready
when a player's Write is finished. If the buffer is too short,
Write finishes immediately without accessing the low audio layer
and the audio context would be ready without playing anything.
This change changes the dummy buffer to have a long enough buffer
so that Write will be wait for acutual audio playing.
Fixes #970
2019-10-23 02:41:12 +09:00
Hajime Hoshi
b78f678700
audio: Bug fix: (*Context).IsReady never returned true unless there is a player
...
The audio context is never ready unless there is a player. This is
problematic when a user tries to play audio after the context is
ready. Play a dummy player to avoid the blocking.
Fixes #969
2019-10-22 23:45:13 +09:00
Hajime Hoshi
689d230cb7
vorbis: Embed files for tests
...
Updates #881
2019-09-15 19:50:56 +09:00
Hajime Hoshi
dbb8a5e873
audio: Block all the players when suspended
...
This avoid to write 0 bytes when the app is in background. This
should reduce CPU usage.
Updates #931
2019-09-07 02:03:59 +09:00
Hajime Hoshi
c52e043006
Add jsutil package for new API of Go 1.13
...
Audio part still cannot be compiled due to Oto.
Fixes #878
2019-06-15 00:49:57 +09:00
Hajime Hoshi
13ce1c28b4
uidriver/mobile: Use timer.NewTimer instead of time.After
...
timer.NewTimer is much better than time.After in terms of memory
usage. See also https://golang.org/pkg/time/#After
2019-06-01 01:30:08 +09:00
Acid147
21abd85a63
Small cleanup ( #877 )
...
* Remove unused variables and constants
* Remove redundant return statement
* Change flock.NewFlock to flock.New
2019-05-26 18:06:43 +09:00
Hajime Hoshi
3ce8babd9b
audio: Remove unnecessary sleepings
2019-05-02 23:57:33 +09:00
Hajime Hoshi
bd85d0e08d
audio: Add TestPauseBeforeInit
...
This confirms that Pause before initialization should not launch
another loop.
2019-05-02 21:39:08 +09:00
Hajime Hoshi
7e2a679b17
audio: Context should be reset for each test
...
As the context remembers the last error, the context should be
re-created for each test.
2019-05-02 21:35:20 +09:00
Hajime Hoshi
396f257629
audio: Fix comments
2019-05-02 04:10:33 +09:00
Hajime Hoshi
876340da17
audio: Bug fix: context.ready should be set true after writing
2019-05-02 03:27:43 +09:00
Hajime Hoshi
2e35d9dc70
audio: Refactoring
2019-05-02 03:21:56 +09:00
Hajime Hoshi
5dd12afd38
audio: Stop the loop when pausing
...
This change reduces the necessity to fill zero bytes.
2019-05-02 03:16:45 +09:00
Hajime Hoshi
5121b072f1
audio: Change init from a variable to a channel
2019-05-02 02:37:32 +09:00
Hajime Hoshi
bea5b0f685
audio: Add comments
2019-05-02 02:11:35 +09:00
Hajime Hoshi
2aa79e0aa4
audio/vorbis/internal/stb: Bug fix: Make the package buildable only under 'js' environment
...
Building `syscall/js` itself can be done only under 'js'
environment.
See also https://travis-ci.org/hajimehoshi/ebiten/builds/526786060
2019-05-01 17:50:59 +09:00
Hajime Hoshi
10fb5e33be
Replace GopherWasm with syscall/js
...
Fixes #857
2019-05-01 17:28:00 +09:00
Hajime Hoshi
c112c31e7e
audio: Reimplement audio by using multiple oto.Player
2019-04-30 18:20:52 +09:00
Hajime Hoshi
339e76afec
audio: Bug fix: Dead lock at seeking
...
When sending something to channels, a lock should not be used,
or the receiver side might be using the same lock.
Bug: #855
2019-04-30 12:51:22 +09:00
Hajime Hoshi
e19479d243
audio: Add comments about explanation how deadlock happens
...
This might be related to #855
2019-04-30 01:41:34 +09:00
Hajime Hoshi
5ecc595ce4
audio: Bug fix: Reset playing state at the end of the readLoop
2019-04-29 22:31:10 +09:00
Hajime Hoshi
d2979e288d
audio: Bug fix: runningReadLoop must be set to true before starting the goroutine
...
This can cause deadlock by multiple goroutines if runningReadLoop
is set to true in the goroutine.
Related to #855 ?
2019-04-29 21:46:26 +09:00
Hajime Hoshi
89f6eba925
Revert "audio: Bug fix: Make ensureReadLoop exactly atomic"
...
This reverts commit 835497edd3
.
Reason: This causes a dead lock at examples/piano with many notes.
This might be related to #855
2019-04-29 14:57:55 +09:00
Hajime Hoshi
fe3e8e376a
audio: Move seeking from the loop to Seek function
...
Seek should work in both cases the loop runs and not. This change
is a preparation.
2019-04-29 02:27:15 +09:00
Hajime Hoshi
c4c6acacf9
audio: Remove (*mux).hasPlayer
2019-04-29 01:01:29 +09:00
Hajime Hoshi
96012b661f
audio: Bug fix: bufferToInt16 can return smaller result
...
Fixes #854
2019-04-29 00:32:57 +09:00
Hajime Hoshi
835497edd3
audio: Bug fix: Make ensureReadLoop exactly atomic
2019-04-29 00:05:54 +09:00
Hajime Hoshi
b1607de99d
audio: Refactoring
2019-04-28 23:58:06 +09:00
Hajime Hoshi
14b6e95217
audio: Use a boolean value to inidicate inited state intead of channels
...
This is a preparation to use oto.Players for Players. By using a
boolean value, suspending state can be detected from multiple
oto.Players.
2019-04-28 19:53:28 +09:00
Hajime Hoshi
fe55e55b7e
audio: Refactoring
2019-04-28 19:53:28 +09:00
Hajime Hoshi
1327e2239c
audio: Use a boolean value to indicate suspending state instead of channels
...
This is a preparation to use oto.Players for Players. By using a
boolean value, suspending state can be detected from multiple
oto.Players.
2019-04-28 19:53:28 +09:00
Hajime Hoshi
2b7705e7ad
audio: AppendHookOnBeforeUpdate should treat multiple calbacks
2019-04-28 19:53:22 +09:00
Hajime Hoshi
31758bf3ab
audio: Remove comment
2019-04-28 19:49:37 +09:00
Hajime Hoshi
2bea7d4e1a
audio: Error on duplicated source
...
Fixes #853
2019-04-28 19:39:46 +09:00
Hajime Hoshi
70a225fd7e
audio: Use dummy hooks from tests
2019-04-28 19:35:59 +09:00
Hajime Hoshi
81549a3523
audio: Bug fix: Remove redundant Unlock
2019-04-28 02:44:32 +09:00
Hajime Hoshi
9fc2ae158c
audio: Bug fix: Close always returned error
2019-04-28 02:22:11 +09:00
Hajime Hoshi
e4f0a0aa04
audio: Bug fix: Remove depenency on finalizer
...
This change fixes playerImpl leak by removing dependency on
finalizer usages. Now readLoop can (or should) be called multiple
times even after closing. Only when (*Player).Close is called
explicitly, the read loop cannot be started again.
Fixes #852
2019-04-28 02:03:55 +09:00
Hajime Hoshi
4f831de008
audio: Remove (*playerImpl).sync and use mutex instead
...
This is a preparation to work syncing wihtout the read-loop.
2019-04-28 01:37:52 +09:00
Hajime Hoshi
acc4ef4e11
audio: Add comments
2019-04-01 01:59:10 +09:00
Hajime Hoshi
df2604c221
audio: Comment about ownership
...
This behavior might be changed at version 2 though (#837 ).
2019-04-01 01:32:14 +09:00
Hajime Hoshi
cba109ebee
audio/mp3: Bug fix: Accept non-io.Closer at Resampling
2019-04-01 00:04:57 +09:00
Hajime Hoshi
49c0b64b60
audio/mp3: Bug fix: Close source when needed
2019-03-31 22:58:22 +09:00
Hajime Hoshi
aa042980ee
audio/mp3: Remove Close calls
...
Close is removed at 14af46a99b
2019-03-31 22:42:34 +09:00
Hajime Hoshi
ed855d6c6c
audio: Refactoring: remove the unused returning value
2019-03-02 04:42:19 +09:00
Hajime Hoshi
a3eddeb50f
Improve panic messages
2019-02-06 23:43:03 -10:00
Hajime Hoshi
a4123a479e
audio: Initialize the context first
...
This is necessary to create an audio's Player before the loop if
we want to create *oto.Player for each *audio.Player.
2019-01-30 00:45:36 +09:00
Hajime Hoshi
13b0d82b6d
audio: Use oto.NewContext
2019-01-30 00:36:47 +09:00
Hajime Hoshi
f16f6cf4b9
audio/internal/convert: Add Float32Reader and NewReaderFromFloat32Reader
2019-01-15 11:46:31 +09:00
Hajime Hoshi
13f6549cb6
audio/vorbis: Remove duplicated decoded data
...
There was duplicated decoded date in audio/vorbis package and Ogg
decoder package. This change removes this duplication and reduces
memory usage.
2019-01-15 03:52:27 +09:00
Hajime Hoshi
6d714a16cf
audio: Remove unneeded 'break'
2019-01-10 02:34:58 +09:00
Hajime Hoshi
a6b3f761f8
audio: Refactoring: Remove dependency on clock package
2019-01-10 00:59:38 +09:00
Hajime Hoshi
28c96d256a
audio: Bug fix: Test compilation error
2019-01-09 23:39:12 +09:00
Hajime Hoshi
14404334e7
audio: Rename players to mux
2019-01-09 22:10:52 +09:00
Hajime Hoshi
e9422a9f2c
audio: Improve test flakiness
2019-01-06 00:11:34 +09:00
Hajime Hoshi
7956e0ebbc
Revert "Revert "audio: No need goroutine for tests""
...
This reverts commit 62a9bb195c
.
2018-12-28 02:18:16 +09:00
Hajime Hoshi
62a9bb195c
Revert "audio: No need goroutine for tests"
...
This reverts commit 7740656054
.
2018-12-28 02:15:11 +09:00
Hajime Hoshi
7740656054
audio: No need goroutine for tests
2018-12-27 03:37:29 +09:00
Hajime Hoshi
ed7552962d
audio: Improve test flakiness
2018-12-27 03:34:27 +09:00
Hajime Hoshi
1760070130
audio: Add comments about GC ( #746 )
2018-12-18 23:07:19 +09:00